public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kenneth Johansson <kenneth@southpole.se>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate formula
Date: Thu, 29 May 2008 22:59:52 +0200	[thread overview]
Message-ID: <1212094792.2236.15.camel@localhost.localdomain> (raw)
In-Reply-To: <1212092779-29359-1-git-send-email-Tsi-Chung.Liew@freescale.com>


On Thu, 2008-05-29 at 15:26 -0500, Tsi-Chung.Liew wrote:
> From: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
> 
> The formula "counter = (u32) (gd->bus_clk / gd->baudrate) / 32"
> can generate the wrong divisor due to integer division truncation.
> Round the calculated divisor value by adding 1/2 the baudrate
> before dividing by the baudrate.
> 
> Signed-off-by: TsiChung Liew <Tsi-Chung.Liew@freescale.com>
> Acked-by: Gerald Van Baren <vanbaren@cideas.com>
> ---
>  drivers/serial/mcfuart.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/serial/mcfuart.c b/drivers/serial/mcfuart.c
> index 88f3eb1..75e85b7 100644
> --- a/drivers/serial/mcfuart.c
> +++ b/drivers/serial/mcfuart.c
> @@ -63,8 +63,8 @@ int serial_init(void)
>  	uart->umr = UART_UMR_SB_STOP_BITS_1;
>  
>  	/* Setting up BaudRate */
> -	counter = (u32) (gd->bus_clk / (gd->baudrate));
> -	counter >>= 5;
> +	counter = (u32) (gd->bus_clk / 32) + (gd->baudrate / 2));

And you compiled this ?? 

> +	counter = counter / gd->baudrate;
>  
>  	/* write to CTUR: divide counter upper byte */
>  	uart->ubg1 = (u8) ((counter & 0xff00) >> 8);

  reply	other threads:[~2008-05-29 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29 20:26 [U-Boot-Users] [PATCH] ColdFire: Fix UART baudrate formula Tsi-Chung.Liew
2008-05-29 20:59 ` Kenneth Johansson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-05-29 22:20 Tsi-Chung.Liew
2008-05-29 17:29 Tsi-Chung.Liew
2008-05-29 17:37 ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212094792.2236.15.camel@localhost.localdomain \
    --to=kenneth@southpole.se \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox