[U-Boot-Users] [PATCH 1/1] Fix I2C for m547x/548x and m5445x processors.

Luigi 'Comio' Mantellini
2008-07-07T16:17:45Z

On lun, 2008-07-07 at 16:59 +0200, Wolfgang Denk wrote:
> In message <1215439715-28742-2-git-send-email-luigi.mantellini@idf-hit.com> you wrote:
....
> > +
>
> What a nightmare of data and code. So many magic numbers, so much
> potential for errors. And for what? Just for I2C support in U-Boot?
>

From your PoV you are right.

> Are you really sure you don't simply want to use the bit-banging
> driver?
>

I just extended the fsl_i2c.c driver that already uses a precomputed
table to setup the fsl i2c. I haven't invented these values but just
copied from the 547x and 5445x manuals. Furthermore, the h/w i2c is more
accurate that the simple bitbanging.

my 2cents.

luigi

> Best regards,
>
> Wolfgang Denk

--
______ Luigi Mantellini
.'______'. R&D - Software
(.' '.) Industrie Dial Face S.p.A.
( :=----=: ) Via Canzo, 4
('.______.') 20068 Peschiera Borromeo (MI), Italy
'.______.' Tel.: +39 02 5167 2813
Fax: +39 02 5167 2459
Ind. Dial Face Email: luigi.mantellini at idf-hit.com
www.idf-hit.com GPG fingerprint: 3DD1 7B71 FBDF 6376 1B4A
B003 175F E979 907E 1650