public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers	to board_eth_init()
Date: Thu, 10 Jul 2008 14:47:53 +0200	[thread overview]
Message-ID: <1215694073.11647.42.camel@localhost> (raw)
In-Reply-To: <1215693933.11647.41.camel@localhost>

On Thu, 2008-07-10 at 14:45 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2008-07-10 at 13:24 +0200, Haavard Skinnemoen wrote:
> > On Sat,  5 Jul 2008 00:08:47 -0700
> > Ben Warren <biggerbadderben@gmail.com> wrote:
> > 
> > > More cleanup of net/eth.c, this time taking care of AVR32 boards.  I got rid
> > > of the board/eth.c files because board_eth_init() needs to be in a file where
> > > there are other strong symbols in order to override the weak board_eth_init() in
> > > net/eth.c.  I've compiled this code  and verified that the strong
> > > board_eth_init() symbols are linked in, but don't have hardware to test on.
> > > If somebody can, please try out and let me know.
> > 
> > Looks good to me, but I don't have the chance to test it.
> > 
> 
> I tried looking into it, but I do not see who is going to call
> board_eth_init() ? Is this supposed to be done in net/eth.c or
> lib_avr32/board.c ?
> 

Cheese, I am blind, just found it almost on top in the eth_initialize()
function.

I will pull the master and see if it works.

<snipp>

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer

  reply	other threads:[~2008-07-10 12:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05  7:08 [U-Boot-Users] [PATCH 0/1] Moved initialization of AVR32 Ethernet controllers to board_eth_init() Ben Warren
2008-07-05  7:08 ` [U-Boot-Users] [PATCH 1/1] " Ben Warren
2008-07-24 10:45   ` Haavard Skinnemoen
2008-07-10 11:24 ` [U-Boot-Users] [PATCH 0/1] " Haavard Skinnemoen
2008-07-10 12:45   ` Hans-Christian Egtvedt
2008-07-10 12:47     ` Hans-Christian Egtvedt [this message]
2008-07-10 12:53       ` Hans-Christian Egtvedt
2008-07-10 20:34         ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215694073.11647.42.camel@localhost \
    --to=hans-christian.egtvedt@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox