public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/15] bootm: move lmb into the bootm_headers_t structure
Date: Fri, 15 Aug 2008 08:24:40 -0500	[thread overview]
Message-ID: <1218806685-3615-10-git-send-email-galak@kernel.crashing.org> (raw)
In-Reply-To: <1218806685-3615-9-git-send-email-galak@kernel.crashing.org>

To allow for persistent state between future bootm subcommands we need
the lmb to exist in a global state.  Moving it into the bootm_headers_t
allows us to do that.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 common/cmd_bootm.c |   11 ++++-------
 include/image.h    |    4 +++-
 lib_m68k/bootm.c   |    2 +-
 lib_ppc/bootm.c    |    2 +-
 lib_sparc/bootm.c  |    2 +-
 5 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 022cef8..dc88e63 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -168,20 +168,17 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	phys_size_t	mem_size;
 	int		ret;
 
-	struct lmb lmb;
-
 	memset ((void *)&images, 0, sizeof (images));
 	images.verify = getenv_yesno ("verify");
-	images.lmb = &lmb;
 
-	lmb_init(&lmb);
+	lmb_init(&images.lmb);
 
 	mem_start = getenv_bootm_low();
 	mem_size = getenv_bootm_size();
 
-	lmb_add(&lmb, (phys_addr_t)mem_start, mem_size);
+	lmb_add(&images.lmb, (phys_addr_t)mem_start, mem_size);
 
-	board_lmb_reserve(&lmb);
+	board_lmb_reserve(&images.lmb);
 
 	/* get kernel image header, start address and length */
 	os_hdr = boot_get_kernel (cmdtp, flag, argc, argv,
@@ -387,7 +384,7 @@ int do_bootm (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 	show_boot_progress (8);
 
-	lmb_reserve(&lmb, load_start, (load_end - load_start));
+	lmb_reserve(&images.lmb, load_start, (load_end - load_start));
 
 	switch (os) {
 	default:			/* handled by (original) Linux case */
diff --git a/include/image.h b/include/image.h
index 653cbc6..c1acd7b 100644
--- a/include/image.h
+++ b/include/image.h
@@ -229,7 +229,9 @@ typedef struct bootm_headers {
 	ulong		ft_len;		/* length of flat device tree */
 
 	int		verify;		/* getenv("verify")[0] != 'n' */
-	struct lmb	*lmb;		/* for memory mgmt */
+#ifndef USE_HOSTCC
+	struct lmb	lmb;		/* for memory mgmt */
+#endif
 } bootm_headers_t;
 
 /*
diff --git a/lib_m68k/bootm.c b/lib_m68k/bootm.c
index 241721d..1c3b9c9 100644
--- a/lib_m68k/bootm.c
+++ b/lib_m68k/bootm.c
@@ -58,7 +58,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag,
 	ulong bootmap_base;
 	bd_t  *kbd;
 	void  (*kernel) (bd_t *, ulong, ulong, ulong, ulong);
-	struct lmb *lmb = images->lmb;
+	struct lmb *lmb = &images->lmb;
 
 	bootmap_base = getenv_bootm_low();
 
diff --git a/lib_ppc/bootm.c b/lib_ppc/bootm.c
index a3e632f..b86169a 100644
--- a/lib_ppc/bootm.c
+++ b/lib_ppc/bootm.c
@@ -73,7 +73,7 @@ do_bootm_linux(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[],
 			  ulong r7, ulong r8, ulong r9);
 	int	ret;
 	ulong	of_size = images->ft_len;
-	struct lmb *lmb = images->lmb;
+	struct lmb *lmb = &images->lmb;
 
 #if defined(CONFIG_OF_LIBFDT)
 	char	*of_flat_tree = images->ft_addr;
diff --git a/lib_sparc/bootm.c b/lib_sparc/bootm.c
index 71d34ba..aac05e4 100644
--- a/lib_sparc/bootm.c
+++ b/lib_sparc/bootm.c
@@ -93,7 +93,7 @@ void do_bootm_linux(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[],
 	unsigned int data, len, checksum;
 	unsigned int initrd_addr, kernend;
 	void (*kernel) (struct linux_romvec *, void *);
-	struct lmb *lmb = images->lmb;
+	struct lmb *lmb = &images->lmb;
 	int ret;
 
 	if (images->legacy_hdr_valid) {
-- 
1.5.5.1

  reply	other threads:[~2008-08-15 13:24 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 13:24 [U-Boot] [PATCH 01/15] Update linux bootm to support ePAPR client interface Kumar Gala
2008-08-15 13:24 ` [U-Boot] [PATCH 02/15] Clean up usage of icache_disable/dcache_disable Kumar Gala
2008-08-15 13:24   ` [U-Boot] [PATCH 03/15] Add command to enable/disable interrupts Kumar Gala
2008-08-15 13:24     ` [U-Boot] [PATCH 04/15] fdt: added the ability to set initrd start/end via chosen command Kumar Gala
2008-08-15 13:24       ` [U-Boot] [PATCH 05/15] fdt: fdt addr w/o any args reports back the current working address Kumar Gala
2008-08-15 13:24         ` [U-Boot] [PATCH 06/15] bootm: refactor entry point code Kumar Gala
2008-08-15 13:24           ` [U-Boot] [PATCH 07/15] bootm: refactor ramdisk locating code Kumar Gala
2008-08-15 13:24             ` [U-Boot] [PATCH 08/15] bootm: refactor fdt locating and relocation code Kumar Gala
2008-08-15 13:24               ` [U-Boot] [PATCH 09/15] bootm: Set working fdt address as part of the bootm flow Kumar Gala
2008-08-15 13:24                 ` Kumar Gala [this message]
2008-08-15 13:24                   ` [U-Boot] [PATCH 11/15] bootm: refactor image detection and os load steps Kumar Gala
2008-08-15 13:24                     ` [U-Boot] [PATCH 12/15] fdt: refactor fdt resize code Kumar Gala
2008-08-15 13:24                       ` [U-Boot] [PATCH 13/15] fdt: refactor initrd related code Kumar Gala
2008-08-15 13:24                         ` [U-Boot] [PATCH 14/15] fdt: Added resize command Kumar Gala
2008-08-15 13:24                           ` [U-Boot] [PATCH 15/15] bootm: refactor do_reset and os boot function args Kumar Gala
2008-08-26 21:48                             ` Wolfgang Denk
2008-08-26 21:46                           ` [U-Boot] [PATCH 14/15] fdt: Added resize command Wolfgang Denk
2008-08-26 21:45                         ` [U-Boot] [PATCH 13/15] fdt: refactor initrd related code Wolfgang Denk
2008-08-26 21:45                         ` Wolfgang Denk
2008-08-26 21:43                       ` [U-Boot] [PATCH 12/15] fdt: refactor fdt resize code Wolfgang Denk
2008-08-26 21:42                     ` [U-Boot] [PATCH 11/15] bootm: refactor image detection and os load steps Wolfgang Denk
2008-08-26 21:38                   ` [U-Boot] [PATCH 10/15] bootm: move lmb into the bootm_headers_t structure Wolfgang Denk
2008-08-26 21:37                 ` [U-Boot] [PATCH 09/15] bootm: Set working fdt address as part of the bootm flow Wolfgang Denk
2008-08-26 21:37               ` [U-Boot] [PATCH 08/15] bootm: refactor fdt locating and relocation code Wolfgang Denk
2008-08-26 21:35             ` [U-Boot] [PATCH 07/15] bootm: refactor ramdisk locating code Wolfgang Denk
2008-08-21 12:02           ` [U-Boot] [PATCH 06/15] bootm: refactor entry point code Kumar Gala
2008-08-26 21:34             ` Wolfgang Denk
2008-08-26 21:47               ` Jerry Van Baren
2008-08-26 21:57                 ` Wolfgang Denk
2008-08-27  0:07                   ` Kumar Gala
2008-08-26 21:31           ` Wolfgang Denk
2008-08-18 23:07         ` [U-Boot] [PATCH 05/15] fdt: fdt addr w/o any args reports back the current working address Wolfgang Denk
2008-08-18 23:23           ` Jerry Van Baren
2008-08-20 22:56         ` Wolfgang Denk
2008-08-18 23:04       ` [U-Boot] [PATCH 04/15] fdt: added the ability to set initrd start/end via chosen command Wolfgang Denk
2008-08-20 22:56       ` Wolfgang Denk
2008-08-18 22:59     ` [U-Boot] [PATCH 03/15] Add command to enable/disable interrupts Wolfgang Denk
2008-08-18 23:18       ` Kumar Gala
2008-08-20 22:53     ` Wolfgang Denk
2008-08-18 22:57   ` [U-Boot] [PATCH 02/15] Clean up usage of icache_disable/dcache_disable Wolfgang Denk
2008-08-18 22:55 ` [U-Boot] [PATCH 01/15] Update linux bootm to support ePAPR client interface Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218806685-3615-10-git-send-email-galak@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox