[U-Boot] [PATCH 02/15] Clean up usage of icache_disable/dcache_disable

Wolfgang Denk
2008-08-18T22:57:41Z

Dear Kumar Gala,

In message <1218806685-3615-2-git-send-email-galak@kernel.crashing.org> you wrote:
> There is no point in disabling the icache on 7xx/74xx/86xx parts and not
> also flushing the icache. All callers of invalidate_l1_instruction_cache()
> call icache_disable() right after. Make it so icache_disable() calls
> invalidate_l1_instruction_cache() for us.
>
> Also, dcache_disable() already calls dcache_flush() so there is no point
> in the explicit calls of dcache_flush().
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> board/Marvell/db64360/db64360.c | 5 -----
> board/Marvell/db64460/db64460.c | 5 -----
> board/esd/cpci750/cpci750.c | 4 ----
> board/freescale/mpc7448hpc2/mpc7448hpc2.c | 2 --
> board/prodrive/p3mx/p3mx.c | 2 --
> common/cmd_bootm.c | 2 --
> cpu/74xx_7xx/cache.S | 4 ++++
> cpu/mpc86xx/cache.S | 4 ++++
> 8 files changed, 8 insertions(+), 20 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Small is beautiful.