From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Replace references to extern console_buffer with a function call
Date: Fri, 15 Aug 2008 15:25:56 -0500 [thread overview]
Message-ID: <1218831956.1273.114.camel@localhost.localdomain> (raw)
In-Reply-To: <20080815200501.7ECF0248CD@gemini.denx.de>
> what is the purpose of this patch? As far as I can see we gain
> nothing, but we lose on memory footpint. I guess there is some
> problem you're trying to fix, but you did not mention it?
I've added a basic "debug serial console" which relies on this patch.
The debug console is a simple command prompt which allows the user to
issue commands before relocating to SDRAM. We've found this feature
very useful for operations such as initially programming SPD data,
debugging hardware issues (SDRAM/I2C). I'll submit the debug console
patches shortly.
I'm not sure if the debug console will be accepted to mainline, but I
think this patch alone is an improvement over the current implementation
of using a global string and multiple external console_buffer
references. I've always thought global variables should be avoided if
there is a reasonable alternative
Best,
Peter
next prev parent reply other threads:[~2008-08-15 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 19:49 [U-Boot] [PATCH] Replace references to extern console_buffer with a function call Peter Tyser
2008-08-15 20:05 ` Wolfgang Denk
2008-08-15 20:25 ` Peter Tyser [this message]
2008-08-15 21:35 ` Wolfgang Denk
2008-08-15 22:27 ` Peter Tyser
2008-08-16 7:50 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218831956.1273.114.camel@localhost.localdomain \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox