From: gvb.uboot at gmail.com <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] libfdt: Forgot one function when cleaning the namespace
Date: Tue, 19 Aug 2008 22:30:36 -0400 [thread overview]
Message-ID: <1219199438-21716-6-git-send-email-gvb.uboot@gmail.com> (raw)
In-Reply-To: <1219199438-21716-1-git-send-email-gvb.uboot@gmail.com>
From: David Gibson <david@gibson.dropbear.id.au>
In commit b6d80a20fc293f3b995c3ce1a6744a5574192125, we renamed all
libfdt functions to be prefixed with fdt_ or _fdt_ to minimise the
chance of collisions with things from whatever package libfdt is
embedded in, pulled into the libfdt build via that environment's
libfdt_env.h.
Except... I missed one. This patch applies the same treatment to
_stringlist_contains(). While we're at it, also make it static since
it's only used in the same file.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
libfdt/fdt_ro.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
index 326d19c..6292a00 100644
--- a/libfdt/fdt_ro.c
+++ b/libfdt/fdt_ro.c
@@ -412,7 +412,8 @@ int fdt_node_offset_by_phandle(const void *fdt, uint32_t phandle)
&phandle, sizeof(phandle));
}
-int _stringlist_contains(const char *strlist, int listlen, const char *str)
+static int _fdt_stringlist_contains(const char *strlist, int listlen,
+ const char *str)
{
int len = strlen(str);
const char *p;
@@ -438,7 +439,7 @@ int fdt_node_check_compatible(const void *fdt, int nodeoffset,
prop = fdt_getprop(fdt, nodeoffset, "compatible", &len);
if (!prop)
return len;
- if (_stringlist_contains(prop, len, compatible))
+ if (_fdt_stringlist_contains(prop, len, compatible))
return 0;
else
return 1;
--
1.5.6.3
next prev parent reply other threads:[~2008-08-20 2:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 2:30 [U-Boot] [PATCH 0/7] libfdt: Update to resync with dtc/libfdt gvb.uboot at gmail.com
2008-08-20 2:30 ` [U-Boot] [PATCH 1/7] dtc: Enable and fix -Wpointer-arith warnings gvb.uboot at gmail.com
2008-08-20 2:30 ` [U-Boot] [PATCH 2/7] dtc: Enable and fix -Wcast-qual warnings gvb.uboot at gmail.com
2008-08-20 2:30 ` [U-Boot] [PATCH 3/7] libfdt: Increase namespace-pollution paranoia gvb.uboot at gmail.com
2008-08-20 2:30 ` [U-Boot] [PATCH 4/7] libfdt: Improve documentation in libfdt.h gvb.uboot at gmail.com
2008-08-20 2:30 ` gvb.uboot at gmail.com [this message]
2008-08-20 2:30 ` [U-Boot] [PATCH 6/7] libfdt: Implement fdt_get_property_namelen() and fdt_getprop_namelen() gvb.uboot at gmail.com
2008-08-20 2:30 ` [U-Boot] [PATCH 7/7] libfdt: Add support for using aliases in fdt_path_offset() gvb.uboot at gmail.com
2008-08-21 1:45 ` [U-Boot] [PATCH 0/7] libfdt: Update to resync with dtc/libfdt Jerry Van Baren
2008-08-21 1:51 ` David Gibson
2008-08-21 2:08 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219199438-21716-6-git-send-email-gvb.uboot@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox