[U-Boot] [PATCH] ppc4xx: Optimize PLB4 Arbiter and Memory Queue settings for PPC 440SP/SPe, PPC405EX and PPC 460EX/GT

Stefan Roese
2008-08-21T08:52:54Z

On Wednesday 20 August 2008, Prodyut Hazarika wrote:
> Resending the patch since it was not copied to Stefan. Stefan, please
> ignore the previous post.
>
> Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX
> processors Moved PLB4 Arbiter register definitions to ppc4xx.h since it is
> shared across processors Optimize Memory Queue settings for PPC440SP/SPE
> and PPC460EX/GT/SX processors Add register bit definitions for Memory Queue
> Configuration registers

Applied to u-boot-ppc4xx. Thanks.

Still a few comments though (for the next time):

- Please don't add too long lines to the commit text. Since tools like
git-log will indent the commit text, please restrict this text to
something like 70 chars per line.
- The line "Resending the patch..." above needs to go below the "---"
line. This way it will not appear in the commit text after applying.
- Don't indent the commit text.
- You still introduced a few too long lines in the code (I already
commented about this). I'll clean this up with a follow up patch.
- Your patch introduces trailing white spaces. I fixed this. Please
take extra care next time. I suggest running checkpatch.pl or
applying the patch to your local repo via git-am. This will give
you some warnings/errors.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================