public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nick Spence <nick.spence@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration
Date: Fri, 22 Aug 2008 23:52:50 -0700	[thread overview]
Message-ID: <12194743703225-git-send-email-nick.spence@freescale.com> (raw)

Set DAT value before DIR values to avoid creating glitches on the
GPIO signals.
---
 cpu/mpc83xx/cpu_init.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c
index 67c9e57..4514dbb 100644
--- a/cpu/mpc83xx/cpu_init.c
+++ b/cpu/mpc83xx/cpu_init.c
@@ -283,12 +283,12 @@ void cpu_init_f (volatile immap_t * im)
 	im->sysconf.lblaw[7].ar = CFG_LBLAWAR7_PRELIM;
 #endif
 #ifdef CFG_GPIO1_PRELIM
-	im->gpio[0].dir = CFG_GPIO1_DIR;
 	im->gpio[0].dat = CFG_GPIO1_DAT;
+	im->gpio[0].dir = CFG_GPIO1_DIR;
 #endif
 #ifdef CFG_GPIO2_PRELIM
-	im->gpio[1].dir = CFG_GPIO2_DIR;
 	im->gpio[1].dat = CFG_GPIO2_DAT;
+	im->gpio[1].dir = CFG_GPIO2_DIR;
 #endif
 }
 
-- 
1.5.2.2

             reply	other threads:[~2008-08-23  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23  6:52 Nick Spence [this message]
2008-08-25 22:26 ` [U-Boot] [PATCH] MPC83XX: Fix GPIO configuration Kim Phillips
2008-08-25 22:44   ` Spence Nick-RXTD10

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12194743703225-git-send-email-nick.spence@freescale.com \
    --to=nick.spence@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox