public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 06/12] autoscript: Move conditional	compilation to Makefile
Date: Thu, 28 Aug 2008 10:26:53 -0500	[thread overview]
Message-ID: <1219937213.11226.108.camel@localhost.localdomain> (raw)
In-Reply-To: <1219919251-3644-6-git-send-email-plagnioj@jcrosoft.com>

Hi Jean-Chritophe,

On Thu, 2008-08-28 at 12:27 +0200, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  common/Makefile                           |    3 +-
>  common/{cmd_autoscript.c => autoscript.c} |   44 --------
>  common/cmd_autoscript.c                   |  158 -----------------------------
>  3 files changed, 2 insertions(+), 203 deletions(-)
>  copy common/{cmd_autoscript.c => autoscript.c} (79%)
> 
> diff --git a/common/Makefile b/common/Makefile
> index 0c8ef5b..92d7a9e 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -31,7 +31,8 @@ COBJS-y += main.o
>  COBJS-$(CONFIG_CMD_BEDBUG) += bedbug.o
>  COBJS-y += circbuf.o
>  COBJS-$(CONFIG_CMD_AMBAPP) += cmd_ambapp.o
> -COBJS-y += cmd_autoscript.o
> +COBJS-$(CONFIG_AUTOSCRIPT)$(CONFIG_CMD_AUTOSCRIPT) += autoscript.o

Will we run into problems when both CONFIG_AUTOSCRIPT and
CONFIG_CMD_AUTOSCRIPT are defined?  Adding the following should account
for that situation:

COBJS-y += $(COBJS-yy)

> +COBJS-$(CONFIG_CMD_AUTOSCRIPT) += cmd_autoscript.o
>  COBJS-$(CONFIG_CMD_BDI) += cmd_bdinfo.o
>  COBJS-$(CONFIG_CMD_BEDBUG) += cmd_bedbug.o
>  COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o

Best,
Peter

  parent reply	other threads:[~2008-08-28 15:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 10:26 [U-Boot] Makefile cleanup and u-boot size reduction Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27 ` [U-Boot] [PATCH 01/12] gunzip: move to lib_generic Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27   ` [U-Boot] [PATCH 02/12] soft_i2c: move to drivers/i2c Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27     ` [U-Boot] [PATCH 03/12] soft_spi: move to drivers/spi Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27       ` [U-Boot] [PATCH 04/12] miiphybb: move to drivers/net Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27         ` [U-Boot] [PATCH 05/12] crc16: move to lib_generic Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27           ` [U-Boot] [PATCH 06/12] autoscript: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27             ` [U-Boot] [PATCH 07/12] miiphyutil: " Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27               ` [U-Boot] [PATCH 08/12] common/Makefile: order by functionality Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27                 ` [U-Boot] [PATCH 09/12] cmd_terminal: remove no need ifdef Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27                   ` [U-Boot] [PATCH 10/12] update linux/list Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27                     ` [U-Boot] [PATCH 11/12] devices: merge to list_head Jean-Christophe PLAGNIOL-VILLARD
2008-08-28 10:27                       ` [U-Boot] [PATCH 12/12] fs: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 13:19                     ` [U-Boot] [PATCH 10/12] update linux/list Wolfgang Denk
2008-08-28 15:26             ` Peter Tyser [this message]
2008-08-28 15:38               ` [U-Boot] [PATCH 06/12] autoscript: Move conditional compilation to Makefile Peter Tyser
2008-08-28 23:47                 ` Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 10:22                   ` [U-Boot] [PATCH 06/12 V2] " Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 10:22                     ` [U-Boot] [PATCH 08/12 V2] common/Makefile: order by functionality Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 13:10                     ` [U-Boot] [PATCH 06/12 V2] autoscript: Move conditional compilation to Makefile Wolfgang Denk
2008-08-28 17:06         ` [U-Boot] [PATCH 04/12] miiphybb: move to drivers/net Ben Warren
2008-08-28 23:48           ` [U-Boot] [PATCH 04/12 V2] miiphybb: move to drivers/net/phy Jean-Christophe PLAGNIOL-VILLARD
2008-08-29  5:23             ` Ben Warren
2008-08-28 10:30 ` [U-Boot] Makefile cleanup and u-boot size reduction Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 10:32 ` [U-Boot] Makefile Pull Request Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 13:22   ` Wolfgang Denk
2008-08-29 20:01     ` Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03       ` [U-Boot] [PATCH 01/12 V3] gunzip: move to lib_generic Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03         ` [U-Boot] [PATCH 02/12 V3] soft_i2c: move to drivers/i2c Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03           ` [U-Boot] [PATCH 03/12 V3] soft_spi: move to drivers/spi Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03             ` [U-Boot] [PATCH 04/12 V3] miiphybb: move to drivers/net/phy Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03               ` [U-Boot] [PATCH 05/12 V3] crc16: move to lib_generic Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:03                 ` [U-Boot] [PATCH 06/12 V3] autoscript: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                   ` [U-Boot] [PATCH 07/12 V3] miiphyutil: " Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                     ` [U-Boot] [PATCH 08/12 V3] common/Makefile: order by functionality Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                       ` [U-Boot] [PATCH 09/12 V3] cmd_terminal: remove no need ifdef Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                         ` [U-Boot] [PATCH 10/12 V3] update linux/list Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                           ` [U-Boot] [PATCH 11/12 V3] devices: merge to list_head Jean-Christophe PLAGNIOL-VILLARD
2008-08-29 20:04                             ` [U-Boot] [PATCH 12/12 V3] fs: Move conditional compilation to Makefile Jean-Christophe PLAGNIOL-VILLARD
2008-08-31  2:36                             ` [U-Boot] [PATCH 2/3] devices: merge to list_head Jean-Christophe PLAGNIOL-VILLARD
2008-08-31  2:36                           ` [U-Boot] [PATCH 1/3] update linux/list Jean-Christophe PLAGNIOL-VILLARD
2008-08-31 22:17       ` [U-Boot] Makefile Pull Request Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219937213.11226.108.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox