public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Bartlomiej Sieka <tur@semihalf.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] FIT: output image load address for type 'firmware', fix debug msg while there
Date: Thu, 18 Sep 2008 17:03:29 +0200	[thread overview]
Message-ID: <1221750210541-git-send-email-tur@semihalf.com> (raw)
In-Reply-To: <12217502093845-git-send-email-tur@semihalf.com>

Now that the auto-update feature uses the 'firmware' type for updates, it is
useful to inspect the load address of such images.

Signed-off-by: Bartlomiej Sieka <tur@semihalf.com>
---
 common/image.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/common/image.c b/common/image.c
index dc8d7dd..0b7bd8d 100644
--- a/common/image.c
+++ b/common/image.c
@@ -1852,7 +1852,10 @@ void fit_print_contents (const void *fit)
  * @p: pointer to prefix string
  *
  * fit_image_print() lists all mandatory properies for the processed component
- * image. If present, hash nodes are printed out as well.
+ * image. If present, hash nodes are printed out as well. Load
+ * address for images of type firmware is also printed out. Since the load
+ * address is not mandatory for firmware images, it will be output as
+ * "unavailable" when not present.
  *
  * returns:
  *     no returned results
@@ -1911,14 +1914,17 @@ void fit_image_print (const void *fit, int image_noffset, const char *p)
 		printf ("%s  OS:           %s\n", p, genimg_get_os_name (os));
 	}
 
-	if ((type == IH_TYPE_KERNEL) || (type == IH_TYPE_STANDALONE)) {
+	if ((type == IH_TYPE_KERNEL) || (type == IH_TYPE_STANDALONE) ||
+		(type == IH_TYPE_FIRMWARE)) {
 		ret = fit_image_get_load (fit, image_noffset, &load);
 		printf ("%s  Load Address: ", p);
 		if (ret)
 			printf ("unavailable\n");
 		else
 			printf ("0x%08lx\n", load);
+	}
 
+	if ((type == IH_TYPE_KERNEL) || (type == IH_TYPE_STANDALONE)) {
 		fit_image_get_entry (fit, image_noffset, &entry);
 		printf ("%s  Entry Point:  ", p);
 		if (ret)
@@ -2844,7 +2850,7 @@ int fit_check_format (const void *fit)
 #if defined(CONFIG_TIMESTAMP) || defined(CONFIG_CMD_DATE) || defined(USE_HOSTCC)
 	/* mandatory / node 'timestamp' property */
 	if (fdt_getprop (fit, 0, FIT_TIMESTAMP_PROP, NULL) == NULL) {
-		debug ("Wrong FIT format: no description\n");
+		debug ("Wrong FIT format: no timestamp\n");
 		return 0;
 	}
 #endif
-- 
1.5.3.4

  parent reply	other threads:[~2008-09-18 15:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 15:03 [U-Boot] Automatic software updates in U-Boot Bartlomiej Sieka
2008-09-18 15:03 ` [U-Boot] [PATCH 1/3] net: Make TFTP server timeout configurable Bartlomiej Sieka
2008-09-18 15:17   ` Jerry Van Baren
2008-09-18 21:54     ` Graeme Russ
2008-09-19  1:37       ` Jerry Van Baren
2008-09-19  5:52     ` Bartlomiej Sieka
2008-09-22 20:42       ` Wolfgang Denk
2008-09-25  6:17         ` Bartlomiej Sieka
2008-09-18 15:03 ` [U-Boot] [PATCH 2/3] Automatic software update from TFTP server Bartlomiej Sieka
2008-09-22 21:03   ` Wolfgang Denk
2008-09-25  8:16     ` Bartlomiej Sieka
2008-09-25  8:55       ` Wolfgang Denk
2008-09-25  9:49         ` Bartlomiej Sieka
2008-09-25 10:01           ` Wolfgang Denk
2008-09-26  8:46             ` Detlev Zundel
2008-09-25 15:33       ` Andrew Dyer
2008-09-25 16:28         ` Kim Phillips
2008-09-25 16:24           ` Jerry Van Baren
2008-09-25 18:17           ` Wolfgang Denk
2008-09-25 19:21             ` Kim Phillips
2008-09-26  8:08               ` Bartlomiej Sieka
2008-09-26  8:29                 ` Wolfgang Denk
2008-09-26  8:29                   ` Bartlomiej Sieka
2008-09-18 15:03 ` Bartlomiej Sieka [this message]
2008-10-01 13:26 ` [U-Boot] Automatic software updates in U-Boot -- version 2 Bartlomiej Sieka
2008-10-13 22:57   ` Wolfgang Denk
2008-10-14 12:42     ` Bartlomiej Sieka
2008-10-14 13:47       ` Wolfgang Denk
2008-10-14 20:07       ` Wolfgang Denk
2008-10-15  9:45         ` Bartlomiej Sieka
2008-10-01 13:26 ` [U-Boot] [PATCH v2 1/6] flash: factor out adjusting of Flash address to the end of sector Bartlomiej Sieka
2008-10-08  7:39   ` Bartlomiej Sieka
2008-10-08  7:47     ` Stefan Roese
2008-10-08  8:05       ` Bartlomiej Sieka
2008-10-08  8:16         ` Wolfgang Denk
2008-10-08 12:02           ` Stefan Roese
2008-10-13 22:28             ` Wolfgang Denk
2008-10-08 17:38           ` Ben Warren
2008-10-13 22:30             ` Wolfgang Denk
2008-10-01 13:26 ` [U-Boot] [PATCH v2 2/6] net: express the first argument to NetSetTimeout() in milliseconds Bartlomiej Sieka
2008-10-06  5:13   ` Ben Warren
2008-10-01 13:26 ` [U-Boot] [PATCH v2 3/6] net: Make TFTP server timeout configurable Bartlomiej Sieka
2008-10-06  5:13   ` Ben Warren
2008-10-01 13:26 ` [U-Boot] [PATCH v2 4/6] Restore alphabetic ordering in common/Makefile Bartlomiej Sieka
2008-10-08 12:29   ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-08 12:58     ` Bartlomiej Sieka
2008-10-08 14:50       ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-09  8:40         ` Bartlomiej Sieka
2008-10-01 13:26 ` [U-Boot] [PATCH v2 5/6] Automatic software update from TFTP server Bartlomiej Sieka
2008-10-13 22:37   ` Wolfgang Denk
2008-10-01 13:26 ` [U-Boot] [PATCH v2 6/6] FIT: output image load address for type 'firmware', fix message while there Bartlomiej Sieka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221750210541-git-send-email-tur@semihalf.com \
    --to=tur@semihalf.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox