public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] XPedite5200 board support
Date: Mon, 01 Dec 2008 14:31:56 -0600	[thread overview]
Message-ID: <1228163516.6206.42.camel@localhost.localdomain> (raw)
In-Reply-To: <1228162644.24649.15.camel@ld0161-tx32>

On Mon, 2008-12-01 at 14:17 -0600, Jon Loeliger wrote:
> On Mon, 2008-12-01 at 13:47 -0600, Peter Tyser wrote:
> > Initial support for Extreme Engineering Solutions XPedite5200 -
> > a MPC8548-based PMC single board computer.
> > 
> > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > ---
> 
> > +/*
> > + * Use L1 as initial stack
> > + */
> > +#define CONFIG_SYS_INIT_RAM_LOCK	1
> 
> *sigh*
> 
> Shouldn't introduce this here either...
> > +#define CONFIG_SYS_INIT_RAM_ADDR	0xe0000000
> > +#define CONFIG_SYS_INIT_RAM_END		0x4000
> > +
> 
> Thanks,
> jdl

Which define are you referring to?  A quick glance looks like these 3
defines are used legitimately.  Am I missing something?

If a define should be removed, would it be possible to accept these
patches?  After they are accepted I'd be happy to submit another patch
to clean up the defines for all boards.  The boards I've used as
references have the similar defines which should also be cleaned up.

Thanks for the feedback,
Peter

  reply	other threads:[~2008-12-01 20:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 19:47 [U-Boot] [PATCH v3 0/2] 85xx: Support for XPedite5200 Peter Tyser
2008-12-01 19:47 ` [U-Boot] [PATCH v3 1/2] 85xx: Add PORDEVSR_PCI1 define Peter Tyser
2008-12-01 19:47   ` [U-Boot] [PATCH v3 2/2] XPedite5200 board support Peter Tyser
2008-12-01 20:17     ` Jon Loeliger
2008-12-01 20:31       ` Peter Tyser [this message]
2008-12-01 22:06         ` Jon Loeliger
2008-12-03 10:35   ` [U-Boot] Problem in Optimizing the Boot Loader in Start.s of MPC85xx Vignesh Kumar B
2008-12-03 18:30     ` Scott Wood
2008-12-04 20:58   ` [U-Boot] [PATCH v3 1/2] 85xx: Add PORDEVSR_PCI1 define Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228163516.6206.42.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox