public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/3] XPedite5370 board support
Date: Thu, 04 Dec 2008 10:43:33 -0600	[thread overview]
Message-ID: <1228409013.6206.303.camel@localhost.localdomain> (raw)
In-Reply-To: <2acbd3e40812040114x36c3646fsd248f38ce6bd91e4@mail.gmail.com>

On Thu, 2008-12-04 at 03:14 -0600, Andy Fleming wrote:
> +       }
> +#else
> +       gur->devdisr |= MPC85xx_DEVDISR_PCIE1; /* disable */
> +#endif /* CONFIG_PCIE2 */
> 
> 
> MPC85xx_DEVDISR_PCIE1 isn't defined anywhere.  Did you miss some
> changes you made to header files?

Thanks for catching that.  I noticed the same DEVDISR_PCIEx value was
being used for PCIE2 and PCIE3 in v2 of the patch so quickly "fixed" it
in v3 by changing the DEVDISR value for PCIE2.  That fix should have
been changing the DEVDISR value for PCIE3, not PCIE2.  I'll resubmit.

Thanks,
Peter

  reply	other threads:[~2008-12-04 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 19:45 [U-Boot] [PATCH v4 0/3]Support for XPedite5370 and misc GPIO Peter Tyser
2008-12-01 19:45 ` [U-Boot] [PATCH v4 1/3] Add support for PCA953x I2C gpio devices Peter Tyser
2008-12-01 19:45   ` [U-Boot] [PATCH v4 2/3] Add support for Maxim's DS4510 I2C device Peter Tyser
2008-12-01 19:45     ` [U-Boot] [PATCH v4 3/3] XPedite5370 board support Peter Tyser
2008-12-04  9:14       ` Andy Fleming
2008-12-04 16:43         ` Peter Tyser [this message]
2008-12-14 11:38     ` [U-Boot] [PATCH v4 2/3] Add support for Maxim's DS4510 I2C device Wolfgang Denk
2008-12-15 23:53       ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1228409013.6206.303.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox