public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand_base: Add timeout for NAND reset command
Date: Wed, 04 Feb 2009 15:29:27 -0600	[thread overview]
Message-ID: <1233782967.7067.338.camel@localhost.localdomain> (raw)
In-Reply-To: <20090204212253.27C538322908@gemini.denx.de>

On Wed, 2009-02-04 at 22:22 +0100, Wolfgang Denk wrote:
> Dear Scott Wood,
> 
> In message <4989FE57.80404@freescale.com> you wrote:
> > Peter Tyser wrote:
> > > The 25ns was calculated based on the addition of trp and trhoh from the
> > > Micron MT29F8G08 datasheet.  Based on the timing diagram for a "Read
> > > Status" cycle I thought this would be the minimum cycle time needed to
> > > read the chip's status.  Other chips (ST, Samsung) I glanced at had > 25
> > > ns read status times as well.
> > > 
> > > I had tried using get_timer() (I believe nand_wait() would have been
> > > perfect to use), but that didn't work due to interrupts being disabled
> > > when NAND is probed.  I didn't consider using get_ticks()...  That seems
> > > much better.  Is get_ticks() available for all platforms when NAND is
> > > initialized?
> 
> get_ticks() not a public interface. It should not be used in any
> common code.
> 
> Please use get_timer().

The problem is that the NAND code is used prior to interrupts being
enabled, thus we can't use get_timer().  I used a hokey delay based on
(read times * number of iterations).  Whats worse, my hokey loop or
get_ticks()?

Thanks,
Peter

  reply	other threads:[~2009-02-04 21:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 19:47 [U-Boot] [PATCH] nand_base: Add timeout for NAND reset command Peter Tyser
2009-02-04 19:54 ` Scott Wood
2009-02-04 20:22   ` Peter Tyser
2009-02-04 20:45     ` Scott Wood
2009-02-04 21:22       ` Wolfgang Denk
2009-02-04 21:29         ` Peter Tyser [this message]
2009-02-04 21:53           ` Wolfgang Denk
2009-02-04 21:31         ` Scott Wood
2009-02-04 21:54           ` Wolfgang Denk
2009-02-05 16:33             ` Peter Tyser
2009-02-05 16:37               ` Scott Wood
2009-02-06 23:30 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233782967.7067.338.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox