public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tsec: Fix a bug in soft-resetting
Date: Wed, 04 Feb 2009 16:12:24 -0600	[thread overview]
Message-ID: <1233785544.7067.448.camel@localhost.localdomain> (raw)
In-Reply-To: <1233707201-12136-1-git-send-email-afleming@freescale.com>

On Tue, 2009-02-03 at 18:26 -0600, Andy Fleming wrote:
> SOFT_RESET must be asserted for at least 3 TX clocks.  Usually, that's about 30
> clock cycles, so it's been mostly working.  But we had no guarantee, and at
> slower bitrates, it's just over a microsecond (over 1000 clock cycles).  This
> enforces a 2 microsecond gap between assertion and deassertion.
> 
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> ---
>  drivers/net/tsec.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index fbc9a6d..4682c8b 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -158,6 +158,7 @@ int tsec_initialize(bd_t * bis, struct tsec_info_struct *tsec_info)
>  
>  	/* Reset the MAC */
>  	priv->regs->maccfg1 |= MACCFG1_SOFT_RESET;
> +	udelay(2);  /* Soft Reset must be asserted for 3 TX clocks */
>  	priv->regs->maccfg1 &= ~(MACCFG1_SOFT_RESET);
>  
>  #if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) \

I tried  the patch out and it resolves a semi-common issue I was seeing
where the 1st received packet would have a CRC error that would result
in an error such as:
=> dhcp
Enet starting in 100BT/HD
Speed: 100, half duplex
BOOTP broadcast 1
Got error 4
BOOTP broadcast 2

Thanks!

Tested-by: Peter Tyser <ptyser@xes-inc.com>

  reply	other threads:[~2009-02-04 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04  0:26 [U-Boot] [PATCH] tsec: Fix a bug in soft-resetting Andy Fleming
2009-02-04 22:12 ` Peter Tyser [this message]
2009-02-06  7:54 ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233785544.7067.448.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox