public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board
@ 2009-03-16 19:00 Dirk Behme
  2009-03-29 18:42 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 5+ messages in thread
From: Dirk Behme @ 2009-03-16 19:00 UTC (permalink / raw)
  To: u-boot

A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
switches. This patch changes the pinmux configuration for those pins.
They were previously set up for unused MMC3_DAT4-7.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---

Patch is against recent mainline commit
'b3dd629e78870ba2dc9f8032978721c0fa02a856'
"Prepare 2009.03-rc2"

---
 board/omap3/overo/overo.h |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Index: u-boot-main/board/omap3/overo/overo.h
===================================================================
--- u-boot-main.orig/board/omap3/overo/overo.h
+++ u-boot-main/board/omap3/overo/overo.h
@@ -185,6 +185,7 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(CSI2_DX0),		(IEN  | PTD | DIS | M0)) /*CSI2_DX0*/\
  MUX_VAL(CP(CSI2_DY0),		(IEN  | PTD | DIS | M0)) /*CSI2_DY0*/\
  MUX_VAL(CP(CSI2_DX1),		(IEN  | PTD | EN  | M4)) /*GPIO_114*/\
+							 /* - PEN_DOWN*/\
  MUX_VAL(CP(CSI2_DY1),		(IEN  | PTU | EN  | M4)) /*GPIO_115*/\
  /*Audio Interface */\
  MUX_VAL(CP(MCBSP2_FSX),	(IEN  | PTD | DIS | M0)) /*McBSP2_FSX*/\
@@ -295,7 +296,7 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(SYS_CLKOUT2),	(IEN  | PTU | EN  | M4)) /*GPIO_186*/\
  MUX_VAL(CP(ETK_CLK_ES2),	(IDIS | PTU | EN  | M2)) /*MMC3_CLK*/\
  MUX_VAL(CP(ETK_CTL_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_CMD*/\
- MUX_VAL(CP(ETK_D0_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT4*/\
+ MUX_VAL(CP(ETK_D0_ES2),	(IEN  | PTU | EN  | M4)) /*GPIO_14*/\
  MUX_VAL(CP(ETK_D1_ES2),	(IEN  | PTD | EN  | M4)) /*GPIO_15 - X_GATE*/\
  MUX_VAL(CP(ETK_D2_ES2),	(IEN  | PTU | EN  | M4)) /*GPIO_16*/\
 							 /* - W2W_NRESET*/\
@@ -303,9 +304,9 @@ const omap3_sysinfo sysinfo = {
  MUX_VAL(CP(ETK_D4_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT0*/\
  MUX_VAL(CP(ETK_D5_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT1*/\
  MUX_VAL(CP(ETK_D6_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT2*/\
- MUX_VAL(CP(ETK_D7_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT7*/\
- MUX_VAL(CP(ETK_D8_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT6*/\
- MUX_VAL(CP(ETK_D9_ES2),	(IEN  | PTU | EN  | M2)) /*MMC3_DAT5*/\
+ MUX_VAL(CP(ETK_D7_ES2),	(IEN  | PTU | EN  | M4)) /*GPIO_21*/\
+ MUX_VAL(CP(ETK_D8_ES2),	(IEN  | PTU | EN  | M4)) /*GPIO_22*/\
+ MUX_VAL(CP(ETK_D9_ES2),	(IEN  | PTU | EN  | M4)) /*GPIO_23*/\
  MUX_VAL(CP(ETK_D10_ES2),	(IDIS | PTD | DIS | M3)) /*HSUSB2_CLK*/\
  MUX_VAL(CP(ETK_D11_ES2),	(IDIS | PTD | DIS | M3)) /*HSUSB2_STP*/\
  MUX_VAL(CP(ETK_D12_ES2),	(IEN  | PTD | DIS | M3)) /*HSUSB2_DIR*/\

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board
  2009-03-16 19:00 [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board Dirk Behme
@ 2009-03-29 18:42 ` Jean-Christophe PLAGNIOL-VILLARD
  2009-03-30 13:29   ` Dirk Behme
  0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-03-29 18:42 UTC (permalink / raw)
  To: u-boot

On 20:00 Mon 16 Mar     , Dirk Behme wrote:
> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
> switches. This patch changes the pinmux configuration for those pins.
> They were previously set up for unused MMC3_DAT4-7.
> 
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
> 
> Patch is against recent mainline commit
> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
> "Prepare 2009.03-rc2"
sorry NACK

Please send it correctly because git am will take the information from the
email Hearder and I do not want to fix it manually

BTW we do need a better api to managen pio setting on the omap3 may be
someting as the AT91 api

Best Regards,
J.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board
  2009-03-29 18:42 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-03-30 13:29   ` Dirk Behme
  2009-03-30 15:05     ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 5+ messages in thread
From: Dirk Behme @ 2009-03-30 13:29 UTC (permalink / raw)
  To: u-boot

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:00 Mon 16 Mar     , Dirk Behme wrote:
>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
>> switches. This patch changes the pinmux configuration for those pins.
>> They were previously set up for unused MMC3_DAT4-7.
>>
>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>> ---
>>
>> Patch is against recent mainline commit
>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
>> "Prepare 2009.03-rc2"
> sorry NACK
> 
> Please send it correctly because git am will take the information from the
> email Hearder and I do not want to fix it manually

Hmm, I sent this patch the same way I did with the other patches. And 
I can't see anything obviously wrong. Please give some details what 
you think might be wrong with this patch (header?).

Dirk

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board
  2009-03-30 13:29   ` Dirk Behme
@ 2009-03-30 15:05     ` Jean-Christophe PLAGNIOL-VILLARD
  2009-03-30 17:44       ` Wolfgang Denk
  0 siblings, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-03-30 15:05 UTC (permalink / raw)
  To: u-boot

On 15:29 Mon 30 Mar     , Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> On 20:00 Mon 16 Mar     , Dirk Behme wrote:
>>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
>>> switches. This patch changes the pinmux configuration for those pins.
>>> They were previously set up for unused MMC3_DAT4-7.
>>>
>>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
>>> ---
>>>
>>> Patch is against recent mainline commit
>>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
>>> "Prepare 2009.03-rc2"
>> sorry NACK
>>
>> Please send it correctly because git am will take the information from the
>> email Hearder and I do not want to fix it manually
>
> Hmm, I sent this patch the same way I did with the other patches. And I 
> can't see anything obviously wrong. Please give some details what you 
> think might be wrong with this patch (header?).
Based on the patch info your not the Author of the patch so it must be the
same in the Mail Header info

Best Regards,
J.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board
  2009-03-30 15:05     ` Jean-Christophe PLAGNIOL-VILLARD
@ 2009-03-30 17:44       ` Wolfgang Denk
  0 siblings, 0 replies; 5+ messages in thread
From: Wolfgang Denk @ 2009-03-30 17:44 UTC (permalink / raw)
  To: u-boot

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090330150504.GD21302@game.jcrosoft.org> you wrote:
>
> >>> A new Overo expansion board uses GPIO 14, 21, 22 and 23 for LED's and
> >>> switches. This patch changes the pinmux configuration for those pins.
> >>> They were previously set up for unused MMC3_DAT4-7.
> >>>
> >>> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> >>> ---
> >>>
> >>> Patch is against recent mainline commit
> >>> 'b3dd629e78870ba2dc9f8032978721c0fa02a856'
> >>> "Prepare 2009.03-rc2"
> >> sorry NACK
> >>
> >> Please send it correctly because git am will take the information from the
> >> email Hearder and I do not want to fix it manually
> >
> > Hmm, I sent this patch the same way I did with the other patches. And I 
> > can't see anything obviously wrong. Please give some details what you 
> > think might be wrong with this patch (header?).
> Based on the patch info your not the Author of the patch so it must be the
> same in the Mail Header info

Or Dirk should have added his own signed-off-by: line, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A girl with a future avoids the man with a past.
                                   -- Evan Esar, "The Humor of Humor"

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-03-30 17:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-16 19:00 [U-Boot] [PATCH] OMAP3: Update Overo pin mux for new expansion board Dirk Behme
2009-03-29 18:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-30 13:29   ` Dirk Behme
2009-03-30 15:05     ` Jean-Christophe PLAGNIOL-VILLARD
2009-03-30 17:44       ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox