[U-Boot] [PATCH] NetLoop initialization bug

Heiko Schocher
2009-03-31T06:36:04Z

Hello Michael,

Michael Zaidman wrote:
> Please see my comments and updated patch below.
>
> On Mon, Mar 30, 2009 at 7:12 AM, Heiko Schocher <hs@denx.de> wrote:
>> Hello Michael,
>>
>> Michael Zaidman wrote:
[...]
>> The following 2 vars are just used, if CONFIG_CMD_CDP
>> is used, can we do a "#if defined" around it?
>>> + NetOurNativeVLAN = getenv_VLAN("nvlan");
>>> + NetOurVLAN = getenv_VLAN("vlan");
>
> These two variables have been initialized in original code for all
> protocols supported by u-boot. As I can see, at least the NetOurVLAN
> is used by most of them. This was the reason for keeping them in place.

Ok.

>> [...]
>>> @@ -443,18 +392,19 @@ restart:
>>> /* Start with a clean slate... */
>>> BootpTry = 0;
>>> NetOurIP = 0;
>>> - NetServerIP = getenv_IPaddr ("serverip");
>>> DhcpRequest(); /* Basically same as BOOTP */
>>> break;
>>> #endif
>>>
>>> case BOOTP:
>>> BootpTry = 0;
>>> + NetOurIP = 0;
>>>
>> why we need this here?
>
> Generally, for the same reason the DHCP does - "Start with a clean state..."
> On the other hand you are right - we do not need to clear the NetOurIP
> address for BOOTP, DHCP and RARP because the current implementation
> does not check it. So it has been removed in my new patch below.

thanks.

> Here is the updated patch:
>
> Subject: [U-Boot] [PATCH] NetLoop initialization bug

Hmm.. can you please add your commit message and your Signed-off-by

thanks
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany