[U-Boot] [PATCH] NetLoop initialization bug

Detlev Zundel
2009-04-02T12:47:02Z

Hi Michael,

> Sorry for the previous mail,
> I have to enable the git operation via gmail on my workstation.

What do you mean by this? Usually you only need a mailer which is
capable to attach things inline. Even better - if you have a direct
access to an mta or an smtp server, use git-send-email after
git-format-patch.

> Meanwhile I created the patch again by diff.

Well this is really more work for the people importing the patches, so
if at all possible, get tghe setup working with the automatically
generated patches.

> The patch fixes the bug of partial initialization of global network
> parameters.
>
> Upon u-boot's start up the first ping command causes a failure of the
> consequent TFTP transfers. It happens in the recently added mechanism of
> NetLoop initialization where initialization of global network parameters is
> separated in the NetInitLoop routine which is called per env_id change.
> Thus, ping request will initialize the network parameters necessary
> for ping operation only, afterwards the env_changed_id will be set
> to the env_id that will prevent all following initialization requests
> from other protocols.
> The problem is that the initialized by ping subset of network parameters
> is not sufficient for other protocols and particularly for TFTP
> which requires the NetServerIp also.
>
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>

Please don't elide your e-mail address here. The consent is that we use
real e-mail addresses in the signed-off-by lines (as you also did in
your previous post). One negative impact for example is that our
statistic scripts will fail for such entries.

Apart from that you have to nudge Ben or Heiko as to the real content.
I only wanted to help get the formalities straight ;)

Cheers
Detlev

--
Number theorists do it perfectly and rationally.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de