[U-Boot] [PATCH] Default to HOSTARCH if ARCH isn't specified

[U-Boot] [PATCH] Default to HOSTARCH if ARCH isn't specified

[Kumar Gala]

Its possible to build natively on several platforms so we might not
explicitly set ARCH but detect it via HOSTARCH.  As such there are
some things that expect ARCH to be set to work correctly.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 Makefile |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index e91c051..c56d6db 100644
--- a/Makefile
+++ b/Makefile
@@ -137,6 +137,10 @@ ifeq ($(ARCH),powerpc)
 ARCH = ppc
 endif
 
+ifndef ARCH
+ARCH = $(HOSTARCH)
+endif
+
 ifeq ($(obj)include/config.mk,$(wildcard $(obj)include/config.mk))
 
 # load ARCH, BOARD, and CPU configuration
-- 
1.6.0.6

[U-Boot] [PATCH] Default to HOSTARCH if ARCH isn't specified

[Jean-Christophe PLAGNIOL-VILLARD]

On 12:03 Mon 20 Apr     , Kumar Gala wrote:
> Its possible to build natively on several platforms so we might not
> explicitly set ARCH but detect it via HOSTARCH.  As such there are
> some things that expect ARCH to be set to work correctly.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

[U-Boot] [PATCH] Default to HOSTARCH if ARCH isn't specified

[Wolfgang Denk]

Dear Kumar Gala,

In message <1240247017-1069-1-git-send-email-galak@kernel.crashing.org> you wrote:
> Its possible to build natively on several platforms so we might not
> explicitly set ARCH but detect it via HOSTARCH.  As such there are
> some things that expect ARCH to be set to work correctly.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  Makefile |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index e91c051..c56d6db 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -137,6 +137,10 @@ ifeq ($(ARCH),powerpc)
>  ARCH = ppc
>  endif
>  
> +ifndef ARCH
> +ARCH = $(HOSTARCH)
> +endif
> +

In current mainline U-Boot, such a patch is not needed (which is just a
friendly version of saying it does not make sense :-), because ARCH
gets loaded from include/config.mk after running "make <board>_config".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I used to think that the brain was the most wonderful  organ  in  my
body. Then I realized who was telling me this."        - Emo Phillips

[U-Boot] [PATCH] Default to HOSTARCH if ARCH isn't specified

[Scott Wood]

Wolfgang Denk wrote:
> Dear Kumar Gala,
> 
> In message <1240247017-1069-1-git-send-email-galak@kernel.crashing.org> you wrote:
>> diff --git a/Makefile b/Makefile
>> index e91c051..c56d6db 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -137,6 +137,10 @@ ifeq ($(ARCH),powerpc)
>>  ARCH = ppc
>>  endif
>>  
>> +ifndef ARCH
>> +ARCH = $(HOSTARCH)
>> +endif
>> +
> 
> In current mainline U-Boot, such a patch is not needed (which is just a
> friendly version of saying it does not make sense :-), because ARCH
> gets loaded from include/config.mk after running "make <board>_config".

In which case, we should probably add "override" to the place where it 
is set, so as to avoid interference from any ARCH variable that might be 
set (we could then remove the powerpc->ppc bit).

-Scott