public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 09/11] fsl_dma: Move dma function prototypes to common header file
Date: Mon, 22 Jun 2009 18:12:48 -0500	[thread overview]
Message-ID: <1245712368.5818.90.camel@localhost.localdomain> (raw)
In-Reply-To: <82F81B7F-A4B1-4E1A-BA35-269A0D7C64AF@kernel.crashing.org>

Hi Kumar,

> > diff --git a/include/asm-ppc/fsl_dma.h b/include/asm-ppc/fsl_dma.h
> > index c9ec6b5..06ecdcd 100644
> > --- a/include/asm-ppc/fsl_dma.h
> > +++ b/include/asm-ppc/fsl_dma.h
> > @@ -94,4 +94,9 @@ typedef struct fsl_dma {
> > 	char	res4[56];
> > } fsl_dma_t;
> >
> > +#ifdef CONFIG_FSL_DMA
> > +void dma_init(void);
> > +int dmacpy(void *dest, const void *src, size_t n);
> > +#endif
> > +
> 
> #ifdef protection here seems kinda pointless

Most boards won't have CONFIG_FSL_DMA defined, but this file will still
be used in the immap_86xx.h files for padding immap_t.  I figured most
users won't have dma_init() or dmacpy() so the protection wouldn't hurt.

Peter

  reply	other threads:[~2009-06-22 23:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 17:09 [U-Boot] [PATCH 00/11] 85xx/86xx dma updates Peter Tyser
2009-05-21 17:09 ` [U-Boot] [PATCH 01/11] fsl: Create common fsl_dma.h for 85xx and 86xx cpus Peter Tyser
2009-06-12 22:21   ` Kumar Gala
2009-05-21 17:10 ` [U-Boot] [PATCH 02/11] 85xx, 86xx: Sync up DMA code Peter Tyser
2009-06-12 22:21   ` Kumar Gala
2009-05-21 17:10 ` [U-Boot] [PATCH 03/11] 85xx, 86xx: Break out DMA code to a common file Peter Tyser
2009-06-12 14:37   ` Kumar Gala
2009-05-21 17:10 ` [U-Boot] [PATCH 04/11] fsl_dma: Add bitfield definitions for common registers Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 05/11] fsl_dma: Update to use proper I/O accessor functions Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 06/11] fsl_dma: Add support for arbitrarily large transfers Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 07/11] fsl_dma: Fix Channel Start bug in dma_check() Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 08/11] 8xxx: Rename dma_xfer() to dmacpy() Peter Tyser
2009-05-21 17:46   ` Scott Wood
2009-05-21 20:25     ` Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 09/11] fsl_dma: Move dma function prototypes to common header file Peter Tyser
2009-06-12 14:41   ` Kumar Gala
2009-06-22 23:12     ` Peter Tyser [this message]
2009-06-30 13:20       ` Kumar Gala
2009-06-30 13:24         ` Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 10/11] 85xx, 86xx: Move dma_init() call to common code Peter Tyser
2009-05-21 17:10 ` [U-Boot] [PATCH 11/11] fsl_dma: Break out common memory initialization function Peter Tyser
2009-05-21 19:37 ` [U-Boot] [PATCH 00/11] 85xx/86xx dma updates Ira Snyder
2009-05-21 20:49   ` Peter Tyser
2009-05-22  7:29     ` Ira Snyder
2009-05-27  3:40   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245712368.5818.90.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox