[U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache

Jean-Christophe PLAGNIOL-VILLARD
2009-07-07T20:31:48Z

On 21:57 Mon 06 Jul , Tom wrote:
> Woodruff, Richard wrote:
> >>From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> >>Behalf Of Tom Rix
> >>Sent: Monday, July 06, 2009 11:48 AM
> >
> >>Since there is only one version of flushing the dcache for
> >>arm_cortex8, rename v7_flush_dcache_all to the the generic
> >>name flush_dcache. Because the function is intended for
> >>only omap3 boards, move the function to the new file
> >>cache_flush.S.
> >
> >Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory).
> >
> I will change the name to cache_ops.S
I prefer cache.S
> flush_dcache was chosen to match other boards/cpu's and one of the
> main reasons for this change. If Jean is ok changing flush_dcache
> to invalidate_dcache, I will make that change too.
invalidate_dcache is fine for me

Best Regards,
J.