public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver
Date: Wed, 08 Jul 2009 09:13:49 -0500	[thread overview]
Message-ID: <1247062429.11207.166.camel@localhost.localdomain> (raw)
In-Reply-To: <200907081113.20158.sr@denx.de>

Hi Stefan,

> > +++ b/include/asm-ppc/config.h
> > @@ -30,8 +30,9 @@
> >  #endif
> >
> >  #ifndef CONFIG_FSL_DMA
> > -#if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)
> > && \ -	(defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx))
> > +#if ((!defined CONFIG_MPC83xx && defined(CONFIG_DDR_ECC) &&	\
> > +	!defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)) ||		\
> > +	(defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA)))
> >  #define CONFIG_FSL_DMA
> >  #endif
> >  #endif
> 
> The #if construct doesn't seem to work for all PPC boards. I have to admit 
> that I don't understand the logic enabling the CONFIG_FSL_DMA define. It would 
> be great if you (or somebody else with the FSL insight) could fix this.

Thanks for the catch.  I'll send a cleanup patch shortly.

Peter

      parent reply	other threads:[~2009-07-08 14:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 22:15 [U-Boot] [PATCH v2 00/12] 8xxx dma updates Peter Tyser
2009-06-30 22:15 ` [U-Boot] [PATCH v2 01/12] 85xx, 86xx: Break out DMA code to a common file Peter Tyser
2009-07-02  4:04   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 02/12] fsl_dma: Add bitfield definitions for common registers Peter Tyser
2009-07-02  4:04   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 03/12] fsl_dma: Use proper I/O access functions Peter Tyser
2009-07-02  4:04   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 04/12] fsl_dma: Add support for arbitrarily large transfers Peter Tyser
2009-07-02  4:07   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 05/12] fsl_dma: Fix Channel Start bug in dma_check() Peter Tyser
2009-07-02  4:08   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 06/12] 8xxx: Rename dma_xfer() to dmacpy() Peter Tyser
2009-07-02  4:08   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 07/12] fsl_dma: Move dma function prototypes to common header file Peter Tyser
2009-07-02  4:13   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 08/12] 85xx, 86xx: Move dma_init() call to common code Peter Tyser
2009-07-02  4:13   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 09/12] fsl_dma: Break out common memory initialization function Peter Tyser
2009-07-02  4:13   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 10/12] fsl_dma: Make DMA transactions snoopable Peter Tyser
2009-07-02  4:13   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 11/12] 83xx: Replace CONFIG_ECC_INIT_VIA_DDRC references Peter Tyser
2009-07-02  4:12   ` Kumar Gala
2009-07-02 15:25     ` Kim Phillips
2009-07-02 16:17   ` Kumar Gala
2009-06-30 22:15 ` [U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver Peter Tyser
2009-07-02 16:17   ` Kumar Gala
2009-07-08  9:13   ` Stefan Roese
2009-07-08 14:07     ` Kumar Gala
2009-07-08 14:30       ` Peter Tyser
2009-07-08 14:36         ` Kumar Gala
2009-07-08 15:24         ` Ira Snyder
2009-07-08 14:13     ` Peter Tyser [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247062429.11207.166.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox