From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Tyser <ptyser@xes-inc.com>
Date: Wed, 08 Jul 2009 09:13:49 -0500
Subject: [U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver
In-Reply-To: <200907081113.20158.sr@denx.de>
References: <cover.1246398582.git.ptyser@xes-inc.com>
	<7562912cc29928bc1eb0ab343fcf22b1b01e0245.1246398582.git.ptyser@xes-inc.com>
	<200907081113.20158.sr@denx.de>
Message-ID: <1247062429.11207.166.camel@localhost.localdomain>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefan,

> > +++ b/include/asm-ppc/config.h
> > @@ -30,8 +30,9 @@
> >  #endif
> >
> >  #ifndef CONFIG_FSL_DMA
> > -#if defined(CONFIG_DDR_ECC) && !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)
> > && \ -	(defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx))
> > +#if ((!defined CONFIG_MPC83xx && defined(CONFIG_DDR_ECC) &&	\
> > +	!defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER)) ||		\
> > +	(defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA)))
> >  #define CONFIG_FSL_DMA
> >  #endif
> >  #endif
> 
> The #if construct doesn't seem to work for all PPC boards. I have to admit 
> that I don't understand the logic enabling the CONFIG_FSL_DMA define. It would 
> be great if you (or somebody else with the FSL insight) could fix this.

Thanks for the catch.  I'll send a cleanup patch shortly.

Peter