From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Tyser Date: Wed, 08 Jul 2009 09:30:01 -0500 Subject: [U-Boot] [PATCH v2 12/12] 83xx: Add support for fsl_dma driver In-Reply-To: <8B14FE48-C89E-4CEF-AD0A-F9F90C299DCA@kernel.crashing.org> References: <7562912cc29928bc1eb0ab343fcf22b1b01e0245.1246398582.git.ptyser@xes-inc.com> <200907081113.20158.sr@denx.de> <8B14FE48-C89E-4CEF-AD0A-F9F90C299DCA@kernel.crashing.org> Message-ID: <1247063401.11207.183.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2009-07-08 at 09:07 -0500, Kumar Gala wrote: > Peter, > > Also, I'm not seeing anyone defining CONFIG_DDR_ECC_INIT_VIA_DMA for > 83xx. I don't see any reason not to use DMA on 83xx. When I submitted the original patch I didn't see any 83xx boards using either CONFIG_ECC_INIT_VIA_DDRCONTROLLER or CONFIG_DDR_ECC_INIT_VIA_DMA. It didn't look like the 83xx platform supported the CONFIG_ECC_INIT_VIA_DDRCONTROLLER option at all, although some 83xx boards make reference to !CONFIG_DDR_ECC_INIT_VIA_DMA. I don't have any 83xx boards to test on and am not that familiar with the 83xx so I didn't look into fixing the inconsistencies. In a perfect world CONFIG_ECC_INIT_VIA_DDRCONTROLLER would be enabled for all 83xx cpus that supported it, and the DMA init would be the default. I'd be happy to send a patch to change the 83xx arch to use DMA to initialize ECC when !CONFIG_ECC_INIT_VIA_DDRCONTROLLER if someone else will test. Do all 83xx CPUs have the Elo DMA controller DMA engine? Best, Peter