[PATCH 1/8] tcpc: Add driver for USB typec port controller (TCPC)

Marek Vasut
2020-10-13T10:14:51Z

On 10/13/20 12:05 PM, Peng Fan wrote:
>> Subject: Re: [PATCH 1/8] tcpc: Add driver for USB typec port controller (TCPC)
>>
>> On 10/13/20 11:39 AM, Peng Fan wrote:
>>>> Subject: Re: [PATCH 1/8] tcpc: Add driver for USB typec port
>>>> controller (TCPC)
>>>>
>>>> On 10/12/20 11:43 AM, Peng Fan wrote:
>>>>>> Subject: Re: [PATCH 1/8] tcpc: Add driver for USB typec port
>>>>>> controller (TCPC)
>>>>>>
>>>>>> On 10/12/20 8:23 AM, Peng Fan wrote:
>>>>>> [...]
>>>>>>> board/freescale/common/Kconfig | 6 +
>>>>>>> board/freescale/common/Makefile | 4 +
>>>>>>> board/freescale/common/tcpc.c | 1018
>>>>>> +++++++++++++++++++++++++++++++
>>>>>>> board/freescale/common/tcpc.h | 469 ++++++++++++++
>>>>>>> 4 files changed, 1497 insertions(+) create mode 100644
>>>>>>> board/freescale/common/tcpc.c create mode
>>>>>> 100644
>>>>>>> board/freescale/common/tcpc.h
>>>>>>
>>>>>> Shouldn't driver be in drivers/ ?
>>>>>
>>>>> You mean drivers/usb/typec as kernel?
>>>>
>>>> Yes, looks much better than putting drivers into board/ , right ?
>>>>
>>>>> There is no common framework now.
>>>>
>>>> What can we do about that ?
>>>
>>> I have no bandwidth to study the new typec area currently. I'll leave
>>> this to Jun and Ye.
>>>
>>> BTW: are you ok to take the ehci-mx6 patches?
>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
>>>
>> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D202112&amp
>> ;dat
>>>
>> a=02%7C01%7Cpeng.fan%40nxp.com%7C9b1ed52ddbf848fff1e408d86f5ddd
>> 1e%7C68
>>>
>> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637381796212195230&a
>> mp;sdata=
>>>
>> BHlWLIhiVEEcRfKVXAQP9ldcyveozTCjpxo%2FrBMLD%2F4%3D&amp;reserved
>> =0
>>
>> Sure, I am waiting for the cleanup patchset:
>
> With alias set in dtsi, we could remove bind function here to calculate req_seq.
> So I would send the dtsi patch to Linux/uboot community, and remove
> the find function.
>
> Do you agree?

I'm not quite sure what this means, so please send a patch and lets see.