public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3 v2] 83xx: Default to using DMA to initialize SDRAM
Date: Tue, 14 Jul 2009 09:42:00 -0500	[thread overview]
Message-ID: <1247582520.30723.4.camel@localhost.localdomain> (raw)
In-Reply-To: <20090714092232.D74C3832E416@gemini.denx.de>

On Tue, 2009-07-14 at 11:22 +0200, Wolfgang Denk wrote:
> Dear Kim,
> 
> In message <1247098309-29122-2-git-send-email-ptyser@xes-inc.com> Peter Tyse wrote:
> > When SDRAM ECC is enabled and CONFIG_ECC_INIT_VIA_DDRCONTROLLER is not
> > defined use DMA to set SDRAM to a known state.  Previously a sequence of
> > 64-bit stores was used.
> > 
> > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > ---
> >  cpu/mpc83xx/spd_sdram.c  |   57 +++------------------------------------------
> >  drivers/dma/fsl_dma.c    |   16 +++++++++----
> >  include/asm-ppc/config.h |    7 ++---
> >  3 files changed, 18 insertions(+), 62 deletions(-)
> 
> It seems this patch (especially the include/asm-ppc/config.h changes)
> fix build problems for some other (non-FSL) boards, so I would like to
> get this in quickly.
> 
> Do you plan to send a pull request including these patches any time
> soon?
> 
> Alternatively, should I go ahead and apply just this patch (1/3)
> directly?

There was some discussion about whether to use DMA to initialize SDRAM
on the 83xx architecture (which this patch does).  After some
benchmarking by Ira Synder it turns out that using DMA is actually
slower than using the initial method of a series of 64-bit writes.  Thus
I'm assuming Kim would prefer not to use DMA and thus this patch should
be discarded.

Kim, let me know if this is the case and I'll resubmit a patch just to
fix the build error.  Patches 2 and 3 are still applicable even if we
discard patch 1.

Best,
Peter

  parent reply	other threads:[~2009-07-14 14:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  0:11 [U-Boot] [PATCH 0/3 v2] DMA ECC update Peter Tyser
2009-07-09  0:11 ` [U-Boot] [PATCH 1/3 v2] 83xx: Default to using DMA to initialize SDRAM Peter Tyser
2009-07-09  0:24   ` [U-Boot] [PATCH 1/3 v2] 83xx: Default to using DMA to initializeSDRAM Liu Dave-R63238
2009-07-09  0:32     ` Peter Tyser
2009-07-09  0:43       ` Liu Dave-R63238
2009-07-09 12:39         ` Jerry Van Baren
2009-07-09 12:51           ` Jerry Van Baren
2009-07-09  0:58       ` Ira W. Snyder
2009-07-09 15:58         ` [U-Boot] [PATCH 1/3 v2] 83xx: Default to using DMA to initialize SDRAM Ira W. Snyder
2009-07-09 17:00           ` Jerry Van Baren
2009-07-14  9:22   ` Wolfgang Denk
2009-07-14 14:41     ` Kumar Gala
2009-07-14 14:42     ` Peter Tyser [this message]
2009-07-14 15:21       ` Wolfgang Denk
2009-07-14 17:32       ` Kim Phillips
2009-07-14 18:37         ` Peter Tyser
2009-07-09  0:11 ` [U-Boot] [PATCH 2/3 v2] 83xx: Add CONFIG_MEM_INIT_VALUE for boards with ECC Peter Tyser
2009-07-09  0:11 ` [U-Boot] [PATCH 3/3 v2] fsl_dma: Fix SDRAM initial value Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247582520.30723.4.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox