From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU
Date: Wed, 15 Jul 2009 09:51:27 -0500 [thread overview]
Message-ID: <1247669487.16908.52.camel@localhost.localdomain> (raw)
In-Reply-To: <20090715163557.08b58415@surf>
On Wed, 2009-07-15 at 16:35 +0200, Thomas Petazzoni wrote:
> Support for the Calao USB A9263 board
You can get rid of the line above. It is nearly identical to the patch
subject and doesn't add any useful info.
<snip>
>
> MAKEALL | 1
> Makefile | 3
You should add an entry to MAINTAINERS
<snip>
> +/* LED */
> +#define CONFIG_AT91_LED
> +#define CONFIG_RED_LED AT91_PIN_PB7 /* this is the power led */
> +#define CONFIG_GREEN_LED AT91_PIN_PB8 /* this is the user1 led */
> +#define CONFIG_YELLOW_LED AT91_PIN_PC29 /* this is the user2 led */
Funky indentation.
<snip>
> +#define ROUND(A, B) (((A) + (B)) & ~((B) - 1))
I'd try and use the round functions already in include/common.h if
possible. Maybe its not possible if this file is included prior to
common.h though, I'm not sure.
Best,
Peter
next prev parent reply other threads:[~2009-07-15 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 12:07 [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU Thomas Petazzoni
2009-07-08 21:42 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-15 14:35 ` Thomas Petazzoni
2009-07-15 14:51 ` Peter Tyser [this message]
2009-07-16 11:39 ` Thomas Petazzoni
2009-07-16 14:52 ` Peter Tyser
2009-07-20 15:40 ` Thomas Petazzoni
2009-07-20 15:51 ` Peter Tyser
2009-07-17 19:41 ` Wolfgang Denk
2009-07-20 15:42 ` Thomas Petazzoni
2009-07-20 21:11 ` Wolfgang Denk
2009-07-22 15:30 ` Thomas Petazzoni
2009-07-22 15:57 ` Peter Tyser
2009-07-22 16:04 ` Thomas Petazzoni
2009-07-22 16:10 ` Peter Tyser
2009-07-22 16:05 ` Albin Tonnerre
2009-07-23 22:35 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-23 22:45 ` Wolfgang Denk
2009-07-23 22:53 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-24 5:38 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247669487.16908.52.camel@localhost.localdomain \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox