[U-Boot] Support for Calao USB A9263 board based on AT91SAM9263 CPU

[Peter Tyser <ptyser@xes-inc.com>]

Hi Thomas,

> > > +#define ROUND(A, B)		(((A) + (B)) & ~((B) - 1))
> > 
> > I'd try and use the round functions already in include/common.h if
> > possible.  Maybe its not possible if this file is included prior to
> > common.h though, I'm not sure.
> 
> Not sure about this one. All at91 boards do it this way, so if a fix
> needs to be done, I'd suggest to make it separatly. Is this ok ?

I don't have the final say here, I'm just giving my opinion.  If it was
possible to clean up, the best way in my would be to fix your board (ie
this patch), then send a separate follow-up patch fixing other boards.
I don't think its too big of a deal either way.

> Below is an updated version of the patch. Not sure it's the right way
> to resend it, though.

Not quite the right way.  As is, all your comments above would go into
U-Boot's changelog, which you don't want.  You should either send your
patch and comments in separate emails, or put any comments you don't
want in the changelog below the --- mentioned below.

> The Calao USB A9263 board is a board manufactured and sold by Calao
> Systems <http://www.calao-systems.com>. Its components are very
> similar to the AT91SAM9263EK board, so its configuration is based on
> the configuration of this board. There are however some differences:
> different clocks, no LCD, etc.
>  
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

You need to add a '---' line here.  Anything from the --- to the first
diff below are only comments and will be discarded when your patch is
applied.

>  MAINTAINERS                       |    4 
>  MAKEALL                           |    1 
>  Makefile                          |    3 
>  board/calao/usb-a9263/Makefile    |   56 ++++++++
>  board/calao/usb-a9263/config.mk   |    1 
>  board/calao/usb-a9263/led.c       |   44 ++++++
>  board/calao/usb-a9263/partition.c |   37 +++++
>  board/calao/usb-a9263/usb-a9263.c |  193 ++++++++++++++++++++++++++++
>  include/configs/usb-a9263.h       |  186 ++++++++++++++++++++++++++
>  9 files changed, 525 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 575a7ec..5c37647 100644
> --- a/MAINTAINERS

<snip>

> +#########################################################################
> diff --git a/board/calao/usb-a9263/config.mk b/board/calao/usb-a9263/config.mk
> new file mode 100644
> index 0000000..ff2cfd1
> --- /dev/null
> +++ b/board/calao/usb-a9263/config.mk
> @@ -0,0 +1 @@
> +TEXT_BASE = 0x23f00000

You should add a copyright header of some sort to config.mk.

Best,
Peter