From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Tyser <ptyser@xes-inc.com>
Date: Mon, 20 Jul 2009 10:51:21 -0500
Subject: [U-Boot] Support for Calao USB A9263 board based on AT91SAM9263
 CPU
In-Reply-To: <20090720174030.24e65e12@surf>
References: <20090701140758.28d7438a@surf>
	<20090708214253.GD26464@game.jcrosoft.org>
	<20090715163557.08b58415@surf>
	<1247669487.16908.52.camel@localhost.localdomain>
	<20090716133929.33a9b77a@surf>
	<1247755963.19222.811.camel@localhost.localdomain>
	<20090720174030.24e65e12@surf>
Message-ID: <1248105081.5896.11.camel@localhost.localdomain>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2009-07-20 at 17:40 +0200, Thomas Petazzoni wrote:
> Le Thu, 16 Jul 2009 09:52:43 -0500,
> Peter Tyser <ptyser@xes-inc.com> a ?crit :
> 
> > I don't have the final say here, I'm just giving my opinion.  If it
> > was possible to clean up, the best way in my would be to fix your
> > board (ie this patch), then send a separate follow-up patch fixing
> > other boards. I don't think its too big of a deal either way.
> 
> Including <common.h> in a include/configs/ configuration file doesn't
> seem to work, unfortunately.

There might be other ways, eg it looks like Wolfgang addressed the issue
in this patch:
http://www.mail-archive.com/u-boot at lists.denx.de/msg17937.html

Does that patch work for you?  I'm assuming it will go in the next
U-Boot release.

> 
> > > +#########################################################################
> > > diff --git a/board/calao/usb-a9263/config.mk
> > > b/board/calao/usb-a9263/config.mk new file mode 100644
> > > index 0000000..ff2cfd1
> > > --- /dev/null
> > > +++ b/board/calao/usb-a9263/config.mk
> > > @@ -0,0 +1 @@
> > > +TEXT_BASE = 0x23f00000
> > 
> > You should add a copyright header of some sort to config.mk.
> 
> In a one-line file, which just contains a factual definition ?

In my opinion yes.  A copyright will explicitly say how the file may be
used, trivial as it may be.  Check out doc/feature-removal-schedule.txt:

What:	GPL cleanup
When:	August 2009
Why:	Over time, a couple of files have sneaked in into the U-Boot
	source code that are either missing a valid GPL license
	header or that carry a license that is incompatible with the
	GPL.
	Such files shall be removed from the U-Boot source tree.
	See
http://www.denx.de/wiki/pub/U-Boot/TaskGplCleanup/u-boot-1.1.2-files
	for an old and probably incomplete list of such files.

You're free to use whatever license you'd like, as long as its GPL
compatible.  There's no harm in adding a license header, right?

Best,
Peter