From: Kenneth Johansson <kenneth@southpole.se>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dlmalloc: Ignore gcc4.4 compiler warnings
Date: Wed, 29 Jul 2009 14:53:29 +0200 [thread overview]
Message-ID: <1248872009.13783.150.camel@localhost.localdomain> (raw)
In-Reply-To: <20090729054728.6269D832E416@gemini.denx.de>
On Wed, 2009-07-29 at 07:47 +0200, Wolfgang Denk wrote:
> Dear Scott,
>
> In message <20090728225244.GA8187@b07421-ec1.am.freescale.net> you wrote:
> >
> > The patch title is bad -- it's not disabling warnings, it's disabling an
> > aspect of C99 that the code is incompatible with (and which is pretty
> > questionable in the first place with such low level code). Note that in
> > Linux, this is disabled for the entire kernel.
>
> I know. But Linux is bigger than U-Boot, and I think we should be able
> to fix the few isolated places that throw such warnings.
>
> > As things stand, GCC may do bad things with that code. With this patch,
> > it may not (at least not this particular sort of bad thing). Those bad
> > things are not limited to the places where it warns -- those are just the
> > violations it detected.
>
> Agreed, and that's why I want to see this fixed.
Personally I feel this optimization to be in the "luxury" category. I'm
not sure it's worth the trouble in a project like u-boot. Maybe it
should be default off and only turned on for specific modules. like
checksum and compression stuff.
next prev parent reply other threads:[~2009-07-29 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 14:23 [U-Boot] [PATCH] drivers/bios_emulator: Fix gcc 4.4 compiler warning Kumar Gala
2009-07-13 14:24 ` [U-Boot] [PATCH] ahci: " Kumar Gala
2009-07-13 14:24 ` [U-Boot] [PATCH] dlmalloc: Ignore gcc4.4 compiler warnings Kumar Gala
2009-07-23 2:05 ` [U-Boot] gcc4.4 warning fix patches Kumar Gala
2009-07-23 19:06 ` [U-Boot] [PATCH] dlmalloc: Ignore gcc4.4 compiler warnings Wolfgang Denk
2009-07-24 16:40 ` Kenneth Johansson
2009-07-26 21:26 ` Wolfgang Denk
2009-07-28 22:52 ` Scott Wood
2009-07-29 5:47 ` Wolfgang Denk
2009-07-29 5:55 ` Kumar Gala
2009-07-29 12:53 ` Kenneth Johansson [this message]
2009-08-07 0:14 ` Kumar Gala
2009-07-23 19:05 ` [U-Boot] [PATCH] ahci: Fix gcc 4.4 compiler warning Wolfgang Denk
2009-07-23 19:03 ` [U-Boot] [PATCH] drivers/bios_emulator: " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248872009.13783.150.camel@localhost.localdomain \
--to=kenneth@southpole.se \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox