public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Reset interrupted i2c slaves (galaxy5200)
Date: Tue, 25 Aug 2009 09:41:40 -0500	[thread overview]
Message-ID: <1251211300.30334.2467.camel@localhost.localdomain> (raw)
In-Reply-To: <20090825135314.M38430@coldhaus.com>

Hi Eric,

On Tue, 2009-08-25 at 08:57 -0500, Eric Millbrandt wrote:
> Reset any i2c devices that may have been interrupted by a system reset.
> Normally this would be accomplished by clocking the line until SCL and SDA
> are released and then sending a start condtiion (From an Atmel datasheet).
> But since there is only write access to these lines on the MPC5200 we can
> only attempt to reset any slave devices by sending more start commands than
> bits the slave is attempting to transmit.

<snip>

> diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
> index e9a4569..eb2cae6 100644
> --- a/include/configs/galaxy5200.h
> +++ b/include/configs/galaxy5200.h
> @@ -81,8 +81,8 @@
>  #endif
>  /* RAMBOOT will be defined automatically in memory section */
>  
> -#define MTDIDS_DEFAULT 		"nor0=physmap-flash.0"
> -#define MTDPARTS_DEFAULT   	"mtdparts=physmap-flash.0:256k(ubootl)," \
> +#define MTDIDS_DEFAULT		"nor0=physmap-flash.0"
> +#define MTDPARTS_DEFAULT	"mtdparts=physmap-flash.0:256k(ubootl)," \
>  	"1792k(kernel),13312k(jffs2),256k(uboot)ro,256k(oftree),-(space)"
>  
>  /*
> @@ -94,7 +94,7 @@
>  #undef	CONFIG_BOOTARGS
>  
>  #define CONFIG_PREBOOT	"echo;"	\
> -	"echo Welcome to U-Boot"\
> +	"echo Welcome to U-Boot;"\
>  	"echo"
>  
>  /*
> @@ -110,6 +110,7 @@
>  #define CONFIG_SYS_I2C_MODULE 2		/* Select I2C module #1 or #2 */
>  #define CONFIG_SYS_I2C_SPEED 100000	/* 100 kHz */
>  #define CONFIG_SYS_I2C_SLAVE 0x7F
> +#define CONFIG_MISC_INIT_F 1           /* Reset i2c busses */
>  
>  /*
>   * EEPROM CAT24WC32 configuration
> @@ -376,7 +377,7 @@
>  #define CONFIG_SYS_BOOTCS_START		CONFIG_SYS_FLASH_BASE
>  #define CONFIG_SYS_BOOTCS_SIZE		CONFIG_SYS_FLASH_SIZE
>  
> -#define CONFIG_SYS_RESET_ADDRESS 	0xff000000
> +#define CONFIG_SYS_RESET_ADDRESS	0xff000000

Other than the "#define CONFIG_MISC_INIT_F 1" change, the modifications
to include/configs/galaxy5200.h should be separated out into a different
patch (if you want to have them committed) as they don't have anything
to do with the patch's title and description.

Best,
Peter

  reply	other threads:[~2009-08-25 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-25 13:57 [U-Boot] [PATCH 2/3] Reset interrupted i2c slaves (galaxy5200) Eric Millbrandt
2009-08-25 14:41 ` Peter Tyser [this message]
2009-08-28  9:47 ` Detlev Zundel
2009-08-28  9:59   ` Detlev Zundel
2009-08-31  8:13   ` Heiko Schocher
2009-08-31 13:17     ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251211300.30334.2467.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox