From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v1] ep8248: add support for device tree and secondary Ethernet interface.
Date: Thu, 03 Sep 2009 10:05:07 -0500 [thread overview]
Message-ID: <1251990307.6005.4.camel@localhost.localdomain> (raw)
In-Reply-To: <loom.20090903T164910-121@post.gmane.org>
Hi Marcel,
On Thu, 2009-09-03 at 14:52 +0000, Marcel Ziswiler wrote:
> ep8248: add support for device tree and secondary Ethernet interface.
This commit message shouldn't be necessary since its identical to your
commit subject.
<snip>
> +
> +#if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT)
> +/*
> + * update "memory" property in the blob
> + */
> +void ft_blob_update(void *blob, bd_t *bd)
> +{
> + int ret;
> + ret = fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
> + if (ret < 0) {
> + printf("ft_blob_update(): cannot set /memory/reg "
> + "property err:%s\n", fdt_strerror(ret));
> + }
> +}
Should this chunk of code should be added to your cpu's ft_cpu_setup()
function instead of here? Then any mpc82xx board can leverage it
instead of reinventing the wheel.
Best,
Peter
next prev parent reply other threads:[~2009-09-03 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 14:52 [U-Boot] [PATCH][v1] ep8248: add support for device tree and secondary Ethernet interface Marcel Ziswiler
2009-09-03 15:05 ` Peter Tyser [this message]
2009-09-04 9:22 ` Marcel ziswiler
2009-09-04 14:41 ` [U-Boot] [PATCH][v2] " Marcel ziswiler
2009-09-04 14:51 ` Peter Tyser
2009-09-07 14:16 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251990307.6005.4.camel@localhost.localdomain \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox