[U-Boot] [PATCH][v1] ep8248: add support for device tree and secondary Ethernet interface.

Peter Tyser
2009-09-03T15:05:07Z

Hi Marcel,

On Thu, 2009-09-03 at 14:52 +0000, Marcel Ziswiler wrote:
> ep8248: add support for device tree and secondary Ethernet interface.

This commit message shouldn't be necessary since its identical to your
commit subject.

<snip>

> +
> +#if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_OF_LIBFDT)
> +/*
> + * update "memory" property in the blob
> + */
> +void ft_blob_update(void *blob, bd_t *bd)
> +{
> + int ret;
> + ret = fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
> + if (ret < 0) {
> + printf("ft_blob_update(): cannot set /memory/reg "
> + "property err:%s\n", fdt_strerror(ret));
> + }
> +}

Should this chunk of code should be added to your cpu's ft_cpu_setup()
function instead of here? Then any mpc82xx board can leverage it
instead of reinventing the wheel.

Best,
Peter