[U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

Wolfgang Denk
2009-09-04T19:28:50Z

Dear Timur Tabi,

In message <4AA15EDE.6080706@freescale.com> you wrote:
>
> Well, that's an extreme case that is board-specific. Perhaps I should do this:
>
> #ifndef CONFIG_I2C_TIMEOUT
> #define CONFIG_I2C_TIMEOUT 1000
> #endif

OK.

> Also, should we be using the same value for the timeout in i2c_wait4bus() and i2c_wait()? It looks like i2c_wait() should have a much shorter timeout than i2c_wait4bus()?

I'd follow Peter's suggestion here. It sounds sane to me.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The biggest difference between time and space is that you can't reuse
time. - Merrick Furst