public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable
Date: Fri, 04 Sep 2009 17:57:48 -0500	[thread overview]
Message-ID: <1252105068.6005.160.camel@localhost.localdomain> (raw)
In-Reply-To: <20090904215900.62178832E8DE@gemini.denx.de>

On Fri, 2009-09-04 at 23:59 +0200, Wolfgang Denk wrote:
> Dear Timur Tabi,
> 
> In message <1252099715-19255-1-git-send-email-timur@freescale.com> you wrote:
> > The value of I2C_TIMEOUT in fsl_i2c.c has several problems.  First, it is
> > defined as CONFIG_HZ/4, but it is used as a count of microseconds, so it makes
> > no sense to derive it from a clock rate.  Second, the current value (250) is
> > too low for some boards, so it needs to be increased.  Third, the timeout
> > necessary for multiple-master arbitration is larger than the timeout for basic
> > read/write operations, so we shouldn't have a single constant for both timeouts.
> > Finally, it would be nice if we could override these values on a per-board
> > basis.
> > 
> > Signed-off-by: Timur Tabi <timur@freescale.com>
> > ---
> >  drivers/i2c/fsl_i2c.c |   24 ++++++++++++++++++++----
> >  1 files changed, 20 insertions(+), 4 deletions(-)
> 
> Acked-by: Wolfgang Denk <wd@denx.de>

Tested-by: Peter Tyser <ptyser@xes-inc.com>
Acked-by: Peter Tyser <ptyser@xes-inc.com>

Looks good to me,
Peter

  reply	other threads:[~2009-09-04 22:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 21:28 [U-Boot] [PATCH] fsl_i2c: increase I2C timeout values and make them configurable Timur Tabi
2009-09-04 21:59 ` Wolfgang Denk
2009-09-04 22:57   ` Peter Tyser [this message]
2009-09-06  9:09 ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252105068.6005.160.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox