public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v1] r7780mp: fix typo in Ethernet chip model number comment.
Date: Tue, 08 Sep 2009 22:41:38 +0200	[thread overview]
Message-ID: <1252442498.5386.67.camel@com-21> (raw)
In-Reply-To: <20090908183751.218B9832E8DE@gemini.denx.de>

On Tue, 2009-09-08 at 20:37 +0200, Wolfgang Denk wrote:
> Your patch numbering is really, really confusing. There is a patch
> posted for the first time numbered as v2, another one as v3, and this
> here is the second version of a patch which is still numbered v1.

Sorry if I confused you, that was not my intention at all, but I truly carefully numbered my patches. Every patch having a v > 1 was already posted here once before:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/67275
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67197

> I completely lost you here.
> 
> I don;t understand if these patches are supposed to be part of a
> series, or if they are independet of each other, or what else these
> random vN additions might mean.  Please eluciadate.

If it would be a series, one would add something like [3/6] or such. So it is no series, just a few very simple patches.

> Also please note that new versions of a patch should contain a
> comment (below the "---" line) that describes what has been changed
> compared to the old version, i. e. here something like: "v2: added
> missing SoB line" or so.

OK, this one is new for me, sorry. Unfortunately the one I looked at did not include any such history neither:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/67181

> Given this confusion, I will ignore the whole batch of 7 patches you
> just sent. Please work on the other review comments, and then decide
> how you want to post them - as series or independent patches. Assume
> version numbering restarts from zero, as I really ignore this current
> patch series.

That's really sad.

Cheers

Marcel Ziswiler

  reply	other threads:[~2009-09-08 20:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 15:24 [U-Boot] [PATCH][v1] r7780mp: fix typo in Ethernet chip model number comment Marcel Ziswiler
2009-09-08 18:37 ` Wolfgang Denk
2009-09-08 20:41   ` Marcel Ziswiler [this message]
2009-09-08 20:52     ` Wolfgang Denk
2009-09-09 19:09 ` [U-Boot] [PATCH][v2] " Marcel Ziswiler
2009-09-10 21:11   ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2009-09-08 15:22 [U-Boot] [PATCH][v1] " Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252442498.5386.67.camel@com-21 \
    --to=marcel@ziswiler.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox