public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH][v1] muas3001: remove BRG clock node fixup to use common mpc8260 code.
@ 2009-09-08 15:29 Marcel Ziswiler
  2009-09-09  6:03 ` Heiko Schocher
  2009-09-09 19:11 ` [U-Boot] [PATCH][v2] " Marcel Ziswiler
  0 siblings, 2 replies; 4+ messages in thread
From: Marcel Ziswiler @ 2009-09-08 15:29 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
---
 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

diff --git a/board/muas3001/muas3001.c b/board/muas3001/muas3001.c
index 8f83dd9..bf4ccb6 100644
--- a/board/muas3001/muas3001.c
+++ b/board/muas3001/muas3001.c
@@ -310,7 +310,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 	int ret, nodeoffset = 0;
 	ulong memory_data[2] = {0};
 	ulong flash_data[4] = {0};
-	ulong freq = 0;
 	ulong	speed = 0;
 
 	memory_data[0] = cpu_to_be32 (bd->bi_memstart);
@@ -359,21 +358,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 			"err:%s\n", fdt_strerror (nodeoffset));
 	}
 
-	/* brg clock */
-	nodeoffset = fdt_path_offset (blob, "/soc/cpm/brg");
-	if (nodeoffset >= 0) {
-		freq = cpu_to_be32 (bd->bi_brgfreq);
-		ret = fdt_setprop (blob, nodeoffset, "clock-frequency", &freq,
-					sizeof (unsigned long));
-	if (ret < 0)
-		printf ("ft_blob_update): cannot set /soc/cpm/brg/clock-frequency "
-			"property err:%s\n", fdt_strerror (ret));
-	} else {
-		/* memory node is required in dts */
-		printf ("ft_blob_update(): cannot find /soc/cpm/brg/clock-frequency node "
-			"err:%s\n", fdt_strerror (nodeoffset));
-	}
-
 	/* baudrate */
 	nodeoffset = fdt_path_offset (blob, "/soc/cpm/serial");
 	if (nodeoffset >= 0) {
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH][v1] muas3001: remove BRG clock node fixup to use common mpc8260 code.
  2009-09-08 15:29 [U-Boot] [PATCH][v1] muas3001: remove BRG clock node fixup to use common mpc8260 code Marcel Ziswiler
@ 2009-09-09  6:03 ` Heiko Schocher
  2009-09-09 19:11 ` [U-Boot] [PATCH][v2] " Marcel Ziswiler
  1 sibling, 0 replies; 4+ messages in thread
From: Heiko Schocher @ 2009-09-09  6:03 UTC (permalink / raw)
  To: u-boot

Hello Marcel,

Marcel Ziswiler wrote:
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
> ---
>  board/muas3001/muas3001.c |   16 ----------------
>  1 files changed, 0 insertions(+), 16 deletions(-)

Unfortunately, I don;t have anymore access to this board, but your
patch looks good to me, so:

Acked-by: Heiko Schocher <hs@denx.de>

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH][v2] muas3001: remove BRG clock node fixup to use common mpc8260 code.
  2009-09-08 15:29 [U-Boot] [PATCH][v1] muas3001: remove BRG clock node fixup to use common mpc8260 code Marcel Ziswiler
  2009-09-09  6:03 ` Heiko Schocher
@ 2009-09-09 19:11 ` Marcel Ziswiler
  2009-09-10 21:12   ` Wolfgang Denk
  1 sibling, 1 reply; 4+ messages in thread
From: Marcel Ziswiler @ 2009-09-09 19:11 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
Acked-by: Heiko Schocher <hs@denx.de>
---
Changes since v1:
- Added Heiko's ack

 board/muas3001/muas3001.c |   16 ----------------
 1 files changed, 0 insertions(+), 16 deletions(-)

diff --git a/board/muas3001/muas3001.c b/board/muas3001/muas3001.c
index 8f83dd9..bf4ccb6 100644
--- a/board/muas3001/muas3001.c
+++ b/board/muas3001/muas3001.c
@@ -310,7 +310,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 	int ret, nodeoffset = 0;
 	ulong memory_data[2] = {0};
 	ulong flash_data[4] = {0};
-	ulong freq = 0;
 	ulong	speed = 0;
 
 	memory_data[0] = cpu_to_be32 (bd->bi_memstart);
@@ -359,21 +358,6 @@ void ft_blob_update (void *blob, bd_t *bd)
 			"err:%s\n", fdt_strerror (nodeoffset));
 	}
 
-	/* brg clock */
-	nodeoffset = fdt_path_offset (blob, "/soc/cpm/brg");
-	if (nodeoffset >= 0) {
-		freq = cpu_to_be32 (bd->bi_brgfreq);
-		ret = fdt_setprop (blob, nodeoffset, "clock-frequency", &freq,
-					sizeof (unsigned long));
-	if (ret < 0)
-		printf ("ft_blob_update): cannot set /soc/cpm/brg/clock-frequency "
-			"property err:%s\n", fdt_strerror (ret));
-	} else {
-		/* memory node is required in dts */
-		printf ("ft_blob_update(): cannot find /soc/cpm/brg/clock-frequency node "
-			"err:%s\n", fdt_strerror (nodeoffset));
-	}
-
 	/* baudrate */
 	nodeoffset = fdt_path_offset (blob, "/soc/cpm/serial");
 	if (nodeoffset >= 0) {
-- 
1.6.4.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH][v2] muas3001: remove BRG clock node fixup to use common mpc8260 code.
  2009-09-09 19:11 ` [U-Boot] [PATCH][v2] " Marcel Ziswiler
@ 2009-09-10 21:12   ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2009-09-10 21:12 UTC (permalink / raw)
  To: u-boot

Dear Marcel Ziswiler,

In message <1252523478.3643.4.camel@com-21> you wrote:
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> ---
> Changes since v1:
> - Added Heiko's ack
> 
>  board/muas3001/muas3001.c |   16 ----------------
>  1 files changed, 0 insertions(+), 16 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Stupidity, like virtue, is its own reward"     - William E. Davidsen

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-09-10 21:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-08 15:29 [U-Boot] [PATCH][v1] muas3001: remove BRG clock node fixup to use common mpc8260 code Marcel Ziswiler
2009-09-09  6:03 ` Heiko Schocher
2009-09-09 19:11 ` [U-Boot] [PATCH][v2] " Marcel Ziswiler
2009-09-10 21:12   ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox