public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [TESTING PATCH] ppc: Relocation test patch
Date: Mon, 14 Sep 2009 17:54:57 -0500	[thread overview]
Message-ID: <1252968897.617.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20090914212644.D9991832E864@gemini.denx.de>

On Mon, 2009-09-14 at 23:26 +0200, Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1252709159-22326-1-git-send-email-ptyser@xes-inc.com> you wrote:
> > ** This patch is only meant to allow others to test relocation, it
> > should not be applied!! **
> > 
> > This patch is a quick hack to enable proper relocation on powerpc
> > boards.  I tested on some mpc85xx-based boards.
> > 
> > I updated the common ppc config.mk and u-boot.lds in cpu/ as needed, but
> > didn't bother to update board-specific ones.  CONFIG_RELOC_FIXUP_WORKS
> > has also been hacked into common.h unconditionally.
> > 
> > So if you want to try out this patch, make sure that you
> > 1. Remove the *(.fixup) entry from the text section in your board's
> > linker script.
> > 
> > 2. Make sure your board's config.mk file includes:
> > PLATFORM_RELFLAGS += -mrelocatable
> > 
> > I'm hoping that relocation will work for all powerpc boards assuming you
> > use a semi-recent version.  I think at least gcc >= 3.4.6 (or maybe even
> > 3.4.5) should work.
> > 
> > It'd be great if people could give feedback if this patch works for
> > them, and if not, how their board breaks.
> 
> I have tested this patch on the following boards / tool chains:
> 
> 
> Tool Chain:	ELDK 3.1.1	ELDK 4.0	ELDK 4.2
> 		gcc-3.3.3	gcc-4.0.0	gcc-4.2.2
> Board:		binutils-2.14	binutils-2.16.1	binutils-2.17.50.0
> TQM834x		OK		OK		OK
> Canyonlands	NOK1		OK		OK
> MPC5121ADS	OK		OK		OK
> Haleakala	OK		OK		OK
> Ocotea		NOK1		OK		OK
> 
> NOK1: build error because old compiler does not accept "-m440" option
> 
> 
> So I would say this looks pretty good :-)

Great!  Thanks for the testing.  I'll submit a proper patch in this
window.  I'll also add a check for the .fixup section to catch those
compilers which don't generate it as Mike suggested in the original
relocation thread.

Best,
Peter

  reply	other threads:[~2009-09-14 22:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-11 22:45 [U-Boot] [TESTING PATCH] ppc: Relocation test patch Peter Tyser
2009-09-14 21:26 ` Wolfgang Denk
2009-09-14 22:54   ` Peter Tyser [this message]
2009-09-16 23:20   ` Peter Tyser
2009-09-17  7:06     ` Joakim Tjernlund
2009-09-17  7:50       ` Wolfgang Denk
2009-09-17  8:39         ` Joakim Tjernlund
2009-09-17 10:15           ` Wolfgang Denk
2009-09-17 12:34             ` Joakim Tjernlund
2009-09-17 12:53               ` Wolfgang Denk
2009-09-17 13:25                 ` Joakim Tjernlund
2009-09-17 21:57                 ` Graeme Russ
2009-09-18  5:44                   ` Joakim Tjernlund
2009-09-17 17:29       ` Peter Tyser
2009-09-18 11:40         ` Joakim Tjernlund
2009-09-18 14:28           ` Peter Tyser
2009-09-18 14:52             ` Joakim Tjernlund
2009-09-18 15:21               ` Peter Tyser
2009-09-18 15:33                 ` Joakim Tjernlund
2009-09-18 16:24                   ` Peter Tyser
2009-09-18 17:21                     ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252968897.617.23.camel@localhost.localdomain \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox