From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Tyser <ptyser@xes-inc.com>
Date: Mon, 14 Sep 2009 17:54:57 -0500
Subject: [U-Boot] [TESTING PATCH] ppc: Relocation test patch
In-Reply-To: <20090914212644.D9991832E864@gemini.denx.de>
References: <1252709159-22326-1-git-send-email-ptyser@xes-inc.com>
	<20090914212644.D9991832E864@gemini.denx.de>
Message-ID: <1252968897.617.23.camel@localhost.localdomain>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 2009-09-14 at 23:26 +0200, Wolfgang Denk wrote:
> Dear Peter Tyser,
> 
> In message <1252709159-22326-1-git-send-email-ptyser@xes-inc.com> you wrote:
> > ** This patch is only meant to allow others to test relocation, it
> > should not be applied!! **
> > 
> > This patch is a quick hack to enable proper relocation on powerpc
> > boards.  I tested on some mpc85xx-based boards.
> > 
> > I updated the common ppc config.mk and u-boot.lds in cpu/ as needed, but
> > didn't bother to update board-specific ones.  CONFIG_RELOC_FIXUP_WORKS
> > has also been hacked into common.h unconditionally.
> > 
> > So if you want to try out this patch, make sure that you
> > 1. Remove the *(.fixup) entry from the text section in your board's
> > linker script.
> > 
> > 2. Make sure your board's config.mk file includes:
> > PLATFORM_RELFLAGS += -mrelocatable
> > 
> > I'm hoping that relocation will work for all powerpc boards assuming you
> > use a semi-recent version.  I think at least gcc >= 3.4.6 (or maybe even
> > 3.4.5) should work.
> > 
> > It'd be great if people could give feedback if this patch works for
> > them, and if not, how their board breaks.
> 
> I have tested this patch on the following boards / tool chains:
> 
> 
> Tool Chain:	ELDK 3.1.1	ELDK 4.0	ELDK 4.2
> 		gcc-3.3.3	gcc-4.0.0	gcc-4.2.2
> Board:		binutils-2.14	binutils-2.16.1	binutils-2.17.50.0
> TQM834x		OK		OK		OK
> Canyonlands	NOK1		OK		OK
> MPC5121ADS	OK		OK		OK
> Haleakala	OK		OK		OK
> Ocotea		NOK1		OK		OK
> 
> NOK1: build error because old compiler does not accept "-m440" option
> 
> 
> So I would say this looks pretty good :-)

Great!  Thanks for the testing.  I'll submit a proper patch in this
window.  I'll also add a check for the .fixup section to catch those
compilers which don't generate it as Mike suggested in the original
relocation thread.

Best,
Peter