public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Remy Bohmer <linux@bohmer.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add error codes/handling for TFTP-server
Date: Wed, 28 Oct 2009 22:13:40 +0100	[thread overview]
Message-ID: <1256764421-27799-6-git-send-email-linux@bohmer.net> (raw)
In-Reply-To: <1256764421-27799-5-git-send-email-linux@bohmer.net>

Signed-off-by: Remy Bohmer <linux@bohmer.net>
---
 net/tftp.c |   32 +++++++++++++++++++++++++++++---
 1 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/net/tftp.c b/net/tftp.c
index cc60a3b..d254f49 100644
--- a/net/tftp.c
+++ b/net/tftp.c
@@ -47,6 +47,16 @@ static int TftpTimeoutCountMax = TIMEOUT_COUNT;
 ulong TftpRRQTimeoutMSecs = TIMEOUT;
 int TftpRRQTimeoutCountMax = TIMEOUT_COUNT;
 
+enum {
+	TFTP_ERR_UNDEFINED           = 0,
+	TFTP_ERR_FILE_NOT_FOUND      = 1,
+	TFTP_ERR_ACCESS_DENIED       = 2,
+	TFTP_ERR_DISK_FULL           = 3,
+	TFTP_ERR_UNEXPECTED_OPCODE   = 4,
+	TFT_ERR_UNKNOWN_TRANSFER_ID  = 5,
+	TFTP_ERR_FILE_ALREADY_EXISTS = 6,
+};
+
 static IPaddr_t TftpServerIP;
 static int	TftpServerPort;		/* The UDP port at their end		*/
 static int	TftpOurPort;		/* The UDP port at our end		*/
@@ -472,11 +482,27 @@ TftpHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len)
 	case TFTP_ERROR:
 		printf ("\nTFTP error: '%s' (%d)\n",
 					pkt + 2, ntohs(*(ushort *)pkt));
-		puts ("Starting again\n\n");
+
+		switch (ntohs(*(ushort *)pkt)) {
+		case TFTP_ERR_FILE_NOT_FOUND:
+		case TFTP_ERR_ACCESS_DENIED:
+			puts("Not retrying...\n");
+			eth_halt();
+			NetState = NETLOOP_FAIL;
+			break;
+		case TFTP_ERR_UNDEFINED:
+		case TFTP_ERR_DISK_FULL:
+		case TFTP_ERR_UNEXPECTED_OPCODE:
+		case TFT_ERR_UNKNOWN_TRANSFER_ID:
+		case TFTP_ERR_FILE_ALREADY_EXISTS:
+		default:
+			puts("Starting again\n\n");
 #ifdef CONFIG_MCAST_TFTP
-		mcast_cleanup();
+			mcast_cleanup();
 #endif
-		NetStartAgain ();
+			NetStartAgain();
+			break;
+		}
 		break;
 	}
 }
-- 
1.6.0.4

  reply	other threads:[~2009-10-28 21:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 21:13 [U-Boot] [PATCH] Building of FIT images does not work Remy Bohmer
2009-10-28 21:13 ` [U-Boot] [PATCH] Fix mingw tools build Remy Bohmer
2009-10-28 21:13   ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Remy Bohmer
2009-10-28 21:13     ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Remy Bohmer
2009-10-28 21:13       ` [U-Boot] [PATCH] Repair the 'netry=once' option Remy Bohmer
2009-10-28 21:13         ` Remy Bohmer [this message]
2009-10-28 21:13           ` [U-Boot] [PATCH] Repair build failure in case PPC is not defined and FIT is beng used Remy Bohmer
2009-10-29 10:53             ` Wolfgang Denk
2009-10-29 11:35               ` Remy Bohmer
2009-10-29 12:36                 ` Wolfgang Denk
2009-11-10  6:30           ` [U-Boot] [PATCH] Add error codes/handling for TFTP-server Ben Warren
2009-11-10  6:28         ` [U-Boot] [PATCH] Repair the 'netry=once' option Ben Warren
2009-11-23 22:48           ` Wolfgang Denk
2009-10-29  5:01       ` [U-Boot] [PATCH] Make the generic unaligned access code safe for unaligned access Stefan Roese
2009-10-29 11:24         ` Remy Bohmer
2009-10-29 14:30           ` Tom
2009-10-29 14:34             ` Remy Bohmer
2009-10-29 15:17               ` Tom
2009-10-29 15:34                 ` Remy Bohmer
2009-10-29 15:40                   ` Stefan Roese
2009-10-29 17:51                     ` Tom
2009-11-23 22:46       ` Wolfgang Denk
2009-11-24  4:05         ` Stefan Roese
2009-11-24 10:07           ` Remy Bohmer
2009-11-24 21:41           ` Wolfgang Denk
2009-11-23 22:44     ` [U-Boot] [PATCH] Add support for CS2 dataflash for Atmel-SPI Wolfgang Denk
2009-11-23 22:43   ` [U-Boot] [PATCH] Fix mingw tools build Wolfgang Denk
2009-11-23 22:43 ` [U-Boot] [PATCH] Building of FIT images does not work Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256764421-27799-6-git-send-email-linux@bohmer.net \
    --to=linux@bohmer.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox