[U-Boot] [PATCH] v2 Linuxstamp II 9260 support

Paul Thomas
2009-11-05T04:10:08Z

On Wed, Nov 4, 2009 at 5:39 PM, Tom <Tom.Rix@windriver.com> wrote:
> Paul Thomas wrote:
>>>
>>> Another partition.c...
>>> Looking for
>>>
>>> ugrep Ulf
>>> ./board/ronetix/pm9263/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/ronetix/pm9261/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91sam9261ek/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91sam9260ek/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91sam9263ek/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91sam9rlek/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91cap9adk/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91rm9200dk/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/atmel/at91rm9200ek/led.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./board/esd/meesc/partition.c
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>> ./include/configs/at91rm9200ek.h
>>> ?* Ulf Samuelsson <ulf@atmel.com>
>>>
>>> Why do we need another copy?
>>> Please move this to arm926ejs/at91/
>>> If you are feeling adventurous, move the others, else I will take
>>> care of it once this change is committed
>>>
>>
>> I think the partition.c file should stay with the board and not move
>> to arm926ejs/at91/. It's probably the case that most of the boards are
>> using the 8MB dataflash with the same partition table, but it is still
>> a board specific configuration.
>>
>
> I have looked at about half of them.
> It looks like partition tables are identical.
> The difference is more entries in the CS table.
>
> I am interested in a way to generalize this file
> and move it to the cpu layer so all the common
> or nearly common files can be reduced to 1 file
>
> Tom
>
>> thanks,
>> Paul
>
>

This structure in partition.c is board specific not cpu specific. Even
if all the current boards are exactly the same there would need to be
a way someone could change this in the future without breaking other
boards. In could be in the .c or .h file if that would make is
simpler. Anyway this is a more general discussion for all the at91
folks.

/*define the area offsets*/
dataflash_protect_t area_list[NB_DATAFLASH_AREA] = {
{0x00000000, 0x000041FF, FLAG_PROTECT_SET, 0, "Bootstrap"},
{0x00004200, 0x000083FF, FLAG_PROTECT_CLEAR, 0, "Environment"},
{0x00008400, 0x00041FFF, FLAG_PROTECT_SET, 0, "U-Boot"},
{0x00042000, 0x00251FFF, FLAG_PROTECT_CLEAR, 0, "Kernel"},
{0x00252000, 0xFFFFFFFF, FLAG_PROTECT_CLEAR, 0, "FS"},
};