public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: John Schmoller <jschmoller@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] env: Group environment variables
Date: Wed, 04 Nov 2009 14:37:44 -0600	[thread overview]
Message-ID: <1257367064.8937.1161.camel@johns> (raw)
In-Reply-To: <200911041536.02492.vapier@gentoo.org>

On Wed, 2009-11-04 at 16:36 -0400, Mike Frysinger wrote:
> On Wednesday 04 November 2009 13:17:12 John Schmoller wrote:
> > On Wed, 2009-11-04 at 13:55 -0400, Mike Frysinger wrote:
> > > On Wednesday 04 November 2009 11:34:12 John Schmoller wrote:
> > > > This patch groups environment variables using a non-invasive protocol.
> > > > Grouping is achieved by setting a "grouping" variable to a string of
> > > > variables, and setting the master grouping variable, "env_groups" to
> > > > the list of these grouping variables.
> > > >
> > > > For instance,
> > > > setenv net ipaddr netmask gatewayip serverip
> > > > setenv boot bootcmd bootdelay bootargs
> > > > setenv env_groups net boot
> > > >
> > > > would print 4 variables grouped under net, 3 variables grouped under
> > > > boot, and the rest of the variables grouped under "other". If
> > > > env_groups is not defined, print behaves normally.
> > > >
> > > > Signed-off-by: John Schmoller <jschmoller@xes-inc.com>
> > > > ---
> > > > I'm interesetd in seeing peoples opinions of this implementation of
> > > >  grouping environment variables.  My major concerns about this
> > > >  implementation are
> > >
> > > my main concern is bloat.  while i guess it would make nicer `printenv`,
> > > i'm not going to use it.  so please put it behind a config option so it
> > > doesnt waste space on all boards.
> > 
> > I can certainly do that.  It is a requested feature on the U-Boot task
> > list[1], so I didn't think that was needed, but I'll do it if that's
> > what people want.
> 
> sure, i'm not saying people other than me dont want it, just that i dont think 
> it's something you can call "core required functionality".  Wolfgang's call of 
> course, but i'd like to see it behind a CONFIG (preferably disabled by 
> default).

Will do.  I'll wait to see if anyone has any other comments about
implementation before resending.

John

  reply	other threads:[~2009-11-04 20:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 16:34 [U-Boot] [RFC] env: Group environment variables John Schmoller
2009-11-04 17:55 ` Mike Frysinger
2009-11-04 18:17   ` John Schmoller
2009-11-04 20:36     ` Mike Frysinger
2009-11-04 20:37       ` John Schmoller [this message]
2009-11-04 22:28       ` Wolfgang Denk
2009-11-05 19:57 ` Wolfgang Denk
2009-11-05 20:25   ` John Schmoller
2009-11-05 22:37     ` Wolfgang Denk
2009-11-05 22:42       ` John Schmoller
2009-11-16 23:15         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257367064.8937.1161.camel@johns \
    --to=jschmoller@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox