public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dave Mitchell <dmitchell@appliedmicro.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY reset sequence
Date: Mon, 14 Dec 2009 15:04:53 -0600	[thread overview]
Message-ID: <1260824693-11874-1-git-send-email-dmitchell@appliedmicro.com> (raw)

Current de-assert reset is not sufficient for the USB PHY reset
on some Canyonlands platforms. The patch adds an assert/de-assert
sequence. This addresses a USB detection problem for devices
attached prior to power-up. The delay lengths are needed for
power to the PHY to stabilize.

Signed-off-by: Jeff Mann <MannJ@embeddedplanet.com>
Signed-off-by: Dave Mitchell <dmitchell@appliedmicro.com>
Acked-by: Tirumala Reddy Marri <tmarri@appliedmicro.com>
---
v1->v2: fixed typo

 board/amcc/canyonlands/canyonlands.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/board/amcc/canyonlands/canyonlands.c b/board/amcc/canyonlands/canyonlands.c
index 13a0dac..6c61122 100644
--- a/board/amcc/canyonlands/canyonlands.c
+++ b/board/amcc/canyonlands/canyonlands.c
@@ -177,8 +177,11 @@ int board_early_init_f(void)
 	/* Remove NOR-FLASH, NAND-FLASH & EEPROM hardware write protection */
 	out_8((void *)CONFIG_SYS_BCSR_BASE + 5, 0);
 
-	/* Enable USB host & USB-OTG */
+	/* Enable USB host & USB-OTG;force assert,then de-assert PHY reset */
+	out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 1);
+	mdelay(100);
 	out_8((void *)CONFIG_SYS_BCSR_BASE + 7, 0);
+	mdelay(100);
 
 	mtsdr(SDR0_SRST1, 0);	/* Pull AHB out of reset default=1 */
 
-- 
1.6.3.2

             reply	other threads:[~2009-12-14 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-14 21:04 Dave Mitchell [this message]
2009-12-14 21:16 ` [U-Boot] [PATCH V2] ppc4xx: Canyonlands: Fix USB host PHY reset sequence Wolfgang Denk
2009-12-14 21:33   ` David Mitchell
2010-01-14 10:18     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260824693-11874-1-git-send-email-dmitchell@appliedmicro.com \
    --to=dmitchell@appliedmicro.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox