From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 5/7] usb_storage: Adjust time-outs
Date: Fri, 10 Aug 2012 20:39:28 +0200 (CEST) [thread overview]
Message-ID: <1266072204.2281819.1344623968588.JavaMail.root@advansee.com> (raw)
In-Reply-To: <CAA3CPjVcGGxhBciiM5uOFM8PbafT0nthtAMW_T24tUv-8A1ZxQ@mail.gmail.com>
Hi Ilya,
On Fri, Aug 10, 2012 at 8:03:12 PM, Ilya Yanok wrote:
> Hi Benoit,
> On Fri, Aug 10, 2012 at 8:23 PM, Beno?t Th?baudeau <
> benoit.thebaudeau at advansee.com > wrote:
> > Adjust time-out value for the new EHCI mechanism.
>
> Could you please be a bit more specific? ;)
> How this timeout is related to the new mechanism? Is it really EHCI
> specific? If it is, that's hardcoding of lower layer details again,
> I think that's undesirable...
Well, I did this specific patch a very long time ago, and I don't remember the
details. I know that things did not work without it in my test conditions at
that time. I've just run again all my tests with the current code on all my
platforms without this patch, and everything works fine. So it was perhaps a
device-related issue rather than an EHCI-related one. Since the rationale for
this patch is no longer clear and things work fine without it, we can probably
drop it. I let you and Marek decide.
> But generally this series looks really good. Thanks a lot!
Great. You're welcome.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-10 18:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 21:50 [U-Boot] [PATCH v3 1/8] ehci: cosmetic: Define used constants Benoît Thébaudeau
2012-08-09 22:25 ` Marek Vasut
2012-08-09 23:13 ` Benoît Thébaudeau
2012-08-09 23:14 ` Marek Vasut
2012-08-09 23:28 ` Benoît Thébaudeau
2012-08-09 23:28 ` Marek Vasut
2012-08-10 0:53 ` Benoît Thébaudeau
2012-08-10 1:12 ` Marek Vasut
2012-08-10 16:21 ` [U-Boot] [PATCH v4 0/7] ehci: Improve performance Benoît Thébaudeau
2012-08-10 16:22 ` [U-Boot] [PATCH v4 1/7] ehci: cosmetic: Define used constants Benoît Thébaudeau
2012-08-10 16:22 ` [U-Boot] [PATCH v4 2/7] ehci-hcd: Boost transfer speed Benoît Thébaudeau
2012-08-10 16:22 ` [U-Boot] [PATCH v4 0/7] ehci: Improve performance Benoît Thébaudeau
2012-08-10 16:23 ` [U-Boot] [PATCH v4 4/7] usb_storage: Remove EHCI constraints Benoît Thébaudeau
2012-08-10 18:34 ` Ilya Yanok
2012-08-10 18:43 ` Benoît Thébaudeau
2012-08-10 19:34 ` Marek Vasut
2012-08-10 16:23 ` [U-Boot] [PATCH v4 5/7] usb_storage: Adjust time-outs Benoît Thébaudeau
2012-08-10 18:03 ` Ilya Yanok
2012-08-10 18:39 ` Benoît Thébaudeau [this message]
2012-08-10 16:26 ` [U-Boot] [PATCH v4 3/7] usb_storage: Restore non-EHCI support Benoît Thébaudeau
2012-08-10 16:27 ` [U-Boot] [PATCH v4 6/7] usb_stor_BBB_transport: Do not delay when not required Benoît Thébaudeau
2012-08-10 16:27 ` [U-Boot] [PATCH v4 7/7] ehci: Optimize qTD allocations Benoît Thébaudeau
2012-08-10 20:07 ` [U-Boot] [PATCH v4 0/7] ehci: Improve performance Marek Vasut
2012-08-11 20:42 ` Benoît Thébaudeau
2012-08-11 22:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266072204.2281819.1344623968588.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox