* [U-Boot] [PATCH 2/7] FAT: cosmetic: Remove useless assignment
@ 2012-07-19 22:01 Benoît Thébaudeau
2012-07-20 13:19 ` [U-Boot] [PATCH v2 3/8] " Benoît Thébaudeau
0 siblings, 1 reply; 3+ messages in thread
From: Benoît Thébaudeau @ 2012-07-19 22:01 UTC (permalink / raw)
To: u-boot
fatlength is not used after this assignment, so it is useless and can be
removed.
Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Cc: Wolfgang Denk <wd@denx.de>
---
.../fs/fat/fat.c | 1 -
1 file changed, 1 deletion(-)
diff --git u-boot-66714b1.orig/fs/fat/fat.c u-boot-66714b1/fs/fat/fat.c
index f6fd457..e628cf7 100644
--- u-boot-66714b1.orig/fs/fat/fat.c
+++ u-boot-66714b1/fs/fat/fat.c
@@ -210,7 +210,6 @@ static __u32 get_fatent (fsdata *mydata, __u32 entry)
if (startblock + getsize > fatlength)
getsize = fatlength - startblock;
- fatlength *= mydata->sect_size; /* We want it in bytes now */
startblock += mydata->fat_sect; /* Offset from start of disk */
if (disk_read(startblock, getsize, bufptr) < 0) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 3/8] FAT: cosmetic: Remove useless assignment
2012-07-19 22:01 [U-Boot] [PATCH 2/7] FAT: cosmetic: Remove useless assignment Benoît Thébaudeau
@ 2012-07-20 13:19 ` Benoît Thébaudeau
2012-09-02 15:15 ` Wolfgang Denk
0 siblings, 1 reply; 3+ messages in thread
From: Benoît Thébaudeau @ 2012-07-20 13:19 UTC (permalink / raw)
To: u-boot
fatlength is not used after this assignment, so it is useless and can be
removed.
Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
Cc: Wolfgang Denk <wd@denx.de>
---
Changes for v2:
- Patch renumbering because of the new v2 1/8.
- Possible code style changes due to the new v2 1/8.
.../fs/fat/fat.c | 1 -
1 file changed, 1 deletion(-)
diff --git u-boot-66714b1.orig/fs/fat/fat.c u-boot-66714b1/fs/fat/fat.c
index 87a1623..48c8844 100644
--- u-boot-66714b1.orig/fs/fat/fat.c
+++ u-boot-66714b1/fs/fat/fat.c
@@ -210,7 +210,6 @@ static __u32 get_fatent(fsdata *mydata, __u32 entry)
if (startblock + getsize > fatlength)
getsize = fatlength - startblock;
- fatlength *= mydata->sect_size; /* We want it in bytes now */
startblock += mydata->fat_sect; /* Offset from start of disk */
if (disk_read(startblock, getsize, bufptr) < 0) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v2 3/8] FAT: cosmetic: Remove useless assignment
2012-07-20 13:19 ` [U-Boot] [PATCH v2 3/8] " Benoît Thébaudeau
@ 2012-09-02 15:15 ` Wolfgang Denk
0 siblings, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2012-09-02 15:15 UTC (permalink / raw)
To: u-boot
Dear Beno?t Th?baudeau,
In message <334701180.332550.1342790391497.JavaMail.root@advansee.com> you wrote:
> fatlength is not used after this assignment, so it is useless and can be
> removed.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
> Changes for v2:
> - Patch renumbering because of the new v2 1/8.
> - Possible code style changes due to the new v2 1/8.
>
> .../fs/fat/fat.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The good Christian should beware of mathematicians and all those who
make empty prophecies. The danger already exists that mathematicians
have made a covenant with the devil to darken the spirit and confine
man in the bonds of Hell." - Saint Augustine
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-02 15:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 22:01 [U-Boot] [PATCH 2/7] FAT: cosmetic: Remove useless assignment Benoît Thébaudeau
2012-07-20 13:19 ` [U-Boot] [PATCH v2 3/8] " Benoît Thébaudeau
2012-09-02 15:15 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox