[U-Boot] [PATCH V2 03/10] 83xx/85xx/86xx: LBC register cleanup

Scott Wood
2010-06-04T20:22:14Z

On Thu, Jun 03, 2010 at 07:37:51PM -0500, Kim Phillips wrote:
> On Wed, 2 Jun 2010 13:12:02 -0500
> Becky Bruce <beckyb@kernel.crashing.org> wrote:
>
> > diff --git a/arch/powerpc/include/asm/config.h b/arch/powerpc/include/asm/config.h
> > index fc3facb..01036f3 100644
> > --- a/arch/powerpc/include/asm/config.h
> > +++ b/arch/powerpc/include/asm/config.h
> > @@ -76,4 +76,10 @@
> > /* Relocation to SDRAM works on all PPC boards */
> > #define CONFIG_RELOC_FIXUP_WORKS
> >
> > +/* Most PPC SOCs have a LBC so define this here */

Even non-Freescale ones?

> > +#if defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) || \
> > + defined(CONFIG_MPC83xx)
> > +#define CONFIG_FSL_LBC

What about PQ2?

> Instead of in the configs (such as what patch 1 in this series
> continues to do), can we do ELBC determination here, based on
> finer-grained configs such as 831x, 837x, etc?

Let's not introduce more huge ifdef lists, please.

If you don't want to specify it on a per-board basis, have a header file per
soc that the board config file includes.

-Scott