[U-Boot] [PATCH V2 03/10] 83xx/85xx/86xx: LBC register cleanup

Becky Bruce
2010-06-02T19:32:44Z

On Jun 2, 2010, at 2:16 PM, Scott Wood wrote:

> On 06/02/2010 01:12 PM, Becky Bruce wrote:
>> +#ifdef CONFIG_NAND_FSL_ELBC
>> + u8 res9[0x8];
>> + u32 fmr; /* Flash Mode Register */
>> + u32 fir; /* Flash Instruction Register */
>> + u32 fcr; /* Flash Command Register */
>> + u32 fbar; /* Flash Block Addr Register */
>> + u32 fpar; /* Flash Page Addr Register */
>> + u32 fbcr; /* Flash Byte Count Register */
>> + u8 res10[0xF08];
>> +#else
>> + u8 res9[0xF28];
>> +#endif
>
> Shouldn't this be CONFIG_FSL_ELBC (or really, CONFIG_SYS_FSL_ELBC,
> as it describes the hardware and not user config)? The existence of
> these fields isn't dependent on whether we're enabling the NAND
> driver (who knows, some board code might want to do something
> directly with it, or someone could just want the NAND SPL for some
> strange reason, or...).

I don't think these fields exist on every ELBC, but I could be
wrong....... I remember digging through a pile of docs but,
unfortunately, I'm WFH today and my nice handy printouts are on my
desk at the office, so I'll have to peek at it tomorrow.

-Becky