From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC
Date: Tue, 15 Jun 2010 21:48:25 +0200 [thread overview]
Message-ID: <1276631305-30648-1-git-send-email-wd@denx.de> (raw)
In-Reply-To: <1276572325-12642-1-git-send-email-ptyser@xes-inc.com>
From: Peter Tyser <ptyser@xes-inc.com>
Previously, standalone applications were compiled with gcc flags that
produced relocatable executables on the PowerPC architecture (eg with
the -mrelocatable and -fPIC flags). There's no reason for these
applications to be fully relocatable at this time since no relocation
fixups are performed on standalone applications.
Additionally, removing the gcc relocation flags results in the entry
point of applications residing at the base of the image. When
a standalone application was relocatable, the entry point was generally
located at an offset into the image which was confusing and prone to
errors.
This change moves the entry point of PowerPC standalone applications
from 0x40004 (usually) to 0x40000.
Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
Signed-off-by: Wolfgang Denk <wd@denx.de>
---
It seems we need to cleanup a few more make variables (+AFLAGS, CPPFLAGS)
examples/standalone/Makefile | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile
index 6ea3b93..5f1f800 100644
--- a/examples/standalone/Makefile
+++ b/examples/standalone/Makefile
@@ -72,6 +72,16 @@ gcclibdir := $(shell dirname `$(CC) -print-libgcc-file-name`)
CPPFLAGS += -I..
+# For PowerPC there's no need to compile standalone applications as a
+# relocatable executable. The relocation data is not needed, and
+# also causes the entry point of the standalone application to be
+# inconsistent.
+ifeq ($(ARCH),powerpc)
+AFLAGS := $(filter-out $(RELFLAGS),$(AFLAGS))
+CFLAGS := $(filter-out $(RELFLAGS),$(CFLAGS))
+CPPFLAGS := $(filter-out $(RELFLAGS),$(CPPFLAGS))
+endif
+
all: $(obj).depend $(OBJS) $(LIB) $(SREC) $(BIN) $(ELF)
#########################################################################
--
1.7.0.1
next prev parent reply other threads:[~2010-06-15 19:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 3:25 [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC Peter Tyser
2010-06-15 19:02 ` Timur Tabi
2010-06-15 19:05 ` Timur Tabi
2010-06-15 19:08 ` Peter Tyser
2010-06-15 19:20 ` Timur Tabi
2010-06-15 19:34 ` Peter Tyser
2010-06-15 19:36 ` Peter Tyser
2010-06-15 19:45 ` Timur Tabi
2010-06-15 20:15 ` Peter Tyser
2010-06-15 20:28 ` Wolfgang Denk
2010-06-15 20:39 ` Peter Tyser
2010-06-15 20:51 ` Wolfgang Denk
2010-06-16 3:37 ` Peter Tyser
2010-06-16 14:02 ` Timur Tabi
2010-06-16 14:51 ` Wolfgang Denk
2010-09-10 19:49 ` Wolfgang Denk
2010-09-10 19:53 ` Timur Tabi
2010-09-10 20:07 ` Peter Tyser
2010-09-10 21:10 ` Wolfgang Denk
2010-09-12 22:38 ` [U-Boot] [PATCH] examples/standalone: Use gcc's -fno-toplevel-reorder Peter Tyser
2010-09-13 2:00 ` Andrew Dyer
2010-09-13 4:48 ` Peter Tyser
2010-09-16 11:49 ` Detlev Zundel
2010-10-12 20:47 ` Wolfgang Denk
2010-06-15 20:39 ` [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC Timur Tabi
2010-06-15 20:54 ` Wolfgang Denk
2010-06-15 21:03 ` Timur Tabi
2010-06-15 22:56 ` Wolfgang Denk
2010-06-15 19:48 ` Wolfgang Denk [this message]
2010-06-29 20:29 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276631305-30648-1-git-send-email-wd@denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox