[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[Felix Radensky]

On P2020RDB eTSEC2 is connected to Vitesse VSC8221 PHY via SGMII.
Current TBI PHY settings for SGMII mode cause link problems on
this platform, link never comes up.

Fix this by making TBI PHY settings configurable and add a working
configuration for P2020RDB.

Signed-off-by: Felix Radensky <felix@embedded-sol.com>
---
 drivers/net/tsec.c          |    6 +++++-
 include/configs/P1_P2_RDB.h |    9 +++++++++
 2 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 3e4c3bd..5fa6f61 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -281,12 +281,16 @@ static uint tsec_local_mdio_read(volatile tsec_mdio_t *phyregs,
 		| TBIANA_FULL_DUPLEX \
 		)
 
-/* Force the TBI PHY into 1000Mbps full duplex when in SGMII mode */
+/* By default force the TBI PHY into 1000Mbps full duplex when in SGMII mode */
+#ifndef CONFIG_TSEC_TBICR_SETTINGS
 #define TBICR_SETTINGS ( \
 		TBICR_PHY_RESET \
 		| TBICR_FULL_DUPLEX \
 		| TBICR_SPEED1_SET \
 		)
+#else
+#define TBICR_SETTINGS CONFIG_TSEC_TBICR_SETTINGS
+#endif /* CONFIG_TSEC_TBICR_SETTINGS */
 
 /* Configure the TBI for SGMII operation */
 static void tsec_configure_serdes(struct tsec_private *priv)
diff --git a/include/configs/P1_P2_RDB.h b/include/configs/P1_P2_RDB.h
index a9b4004..4b7e190 100644
--- a/include/configs/P1_P2_RDB.h
+++ b/include/configs/P1_P2_RDB.h
@@ -425,6 +425,15 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_ETHPRIME		"eTSEC1"
 
 #define CONFIG_PHY_GIGE		1	/* Include GbE speed/duplex detection */
+
+/* TBI PHY configuration for SGMII mode */
+#define CONFIG_TSEC_TBICR_SETTINGS ( \
+		TBICR_PHY_RESET \
+		| TBICR_ANEG_ENABLE \
+		| TBICR_FULL_DUPLEX \
+		| TBICR_SPEED1_SET \
+		)
+
 #endif	/* CONFIG_TSEC_ENET */
 
 /*
-- 
1.5.4.3

[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[Andy Fleming]

On Sun, Jun 27, 2010 at 5:57 PM, Felix Radensky <felix@embedded-sol.com> wrote:
> On P2020RDB eTSEC2 is connected to Vitesse VSC8221 PHY via SGMII.
> Current TBI PHY settings for SGMII mode cause link problems on
> this platform, link never comes up.
>
> Fix this by making TBI PHY settings configurable and add a working
> configuration for P2020RDB.
>
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>

Acked-by: Andy Fleming <afleming@freescale.com>

[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[Wolfgang Denk]

Dear Felix Radensky,

In message <1277679459-9453-1-git-send-email-felix@embedded-sol.com> you wrote:
> On P2020RDB eTSEC2 is connected to Vitesse VSC8221 PHY via SGMII.
> Current TBI PHY settings for SGMII mode cause link problems on
> this platform, link never comes up.
> 
> Fix this by making TBI PHY settings configurable and add a working
> configuration for P2020RDB.
> 
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> ---
>  drivers/net/tsec.c          |    6 +++++-
>  include/configs/P1_P2_RDB.h |    9 +++++++++
>  2 files changed, 14 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man did not weave the web of life; he  is  merely  a  strand  in  it.
Whatever he does to the web, he does to himself.     - Seattle [1854]

[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[Peter Tyser]

On Tue, 2010-06-29 at 21:02 +0200, Wolfgang Denk wrote:
> Dear Felix Radensky,
> 
> In message <1277679459-9453-1-git-send-email-felix@embedded-sol.com> you wrote:
> > On P2020RDB eTSEC2 is connected to Vitesse VSC8221 PHY via SGMII.
> > Current TBI PHY settings for SGMII mode cause link problems on
> > this platform, link never comes up.
> > 
> > Fix this by making TBI PHY settings configurable and add a working
> > configuration for P2020RDB.
> > 
> > Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> > ---
> >  drivers/net/tsec.c          |    6 +++++-
> >  include/configs/P1_P2_RDB.h |    9 +++++++++
> >  2 files changed, 14 insertions(+), 1 deletions(-)
> 
> Applied, thanks.

A little late, but:
Acked-by: Peter Tyser <ptyser@xes-inc.com>
Tested-by: Peter Tyser <ptyser@xes-inc.com>

Peter

[U-Boot] [PATCH] tsec: Fix eTSEC2 link problem on P2020RDB

[Wolfgang Denk]

Dear Peter Tyser,

In message <1277838432.31352.197.camel@petert> you wrote:
>
> > Applied, thanks.
> 
> A little late, but:
> Acked-by: Peter Tyser <ptyser@xes-inc.com>
> Tested-by: Peter Tyser <ptyser@xes-inc.com>

Not too late. Added, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of COBOL cripples the mind; its teaching  should,  therefore,
be regarded as a criminal offense.                   - E. W. Dijkstra