From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Sakoman Date: Thu, 01 Jul 2010 12:40:30 -0700 Subject: [U-Boot] [PATCH v4 0/6] Add support for TI OMAP4 SDP and Panda In-Reply-To: <0554BEF07D437848AF01B9C9B5F0BC5D9EF5E391@dlee01.ent.ti.com> References: <1277159650-18529-1-git-send-email-steve@sakoman.com> <0554BEF07D437848AF01B9C9B5F0BC5D9EEC573C@dlee01.ent.ti.com> <1277992755.2091.28.camel@quadra> <0554BEF07D437848AF01B9C9B5F0BC5D9EEC5F13@dlee01.ent.ti.com> <1277997865.2091.97.camel@quadra> <0554BEF07D437848AF01B9C9B5F0BC5D9EF5E391@dlee01.ent.ti.com> Message-ID: <1278013230.6989.30.camel@quadra> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2010-07-01 at 11:01 -0500, Paulraj, Sandeep wrote: > > Yes, I don't think that the 2 errors are related to my patches > > (am3517_evm_config and s5p_goni_config). Neither of those boards seem > > to have made it into boards.cfg > > That seems to be the reason > > > > Is this something that you want me to submit a fix patch for, or are > > those board maintainers going to handle this? > > If you have time then it would be nice to get a patch with the entries in boards.cfg OK, done: http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=ecd7cc87cd2ff143ab4508b15463c679f3b140c0 I will also submit it to the list separately. > > The two warnings are also not caused by my patch, that issue has always > > been there for any board that defines CMD_MMC and > > CONFIG_SYS_MMC_SET_DEV. Granted, no boards up to now make use of that > > feature :-) > > > > I think the solution is simply to add a prototype for the mmc_set_dev > > function to mmc.h > > > > I can do this as a separate fixit patch unrelated to my series, or I can > > add it to the "OMAP: mmc: add support for second and third mmc channels" > > and resubmit the patch series. The latter might make sense since my two > > boards are the first to actually make use of the CONFIG_SYS_MMC_SET_DEV > > functionality. > > > > Which would you prefer? > > Just submit a new patch to get rid of the compile issues. No need to resubmit the original patch or the series. That too is done and will also be sent to the list separately: http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=5ec49bc3538adf4325989189858003f5a4cbfac0 After those two patches a MAKEALL gives: Configuring for am3517_evm board... text data bss dec hex filename 162982 9196 201312 373490 5b2f2 ./u-boot Configuring for devkit8000 board... text data bss dec hex filename 201755 10124 214484 426363 6817b ./u-boot Configuring for mx51evk board... text data bss dec hex filename 128874 4956 216924 350754 55a22 ./u-boot Configuring for omap3_beagle board... text data bss dec hex filename 191724 9996 202424 404144 62ab0 ./u-boot Configuring for omap3_overo board... text data bss dec hex filename 181664 9684 210440 401788 6217c ./u-boot Configuring for omap3_evm board... text data bss dec hex filename 211952 9544 257708 479204 74fe4 ./u-boot Configuring for omap3_pandora board... text data bss dec hex filename 163855 9252 200544 373651 5b393 ./u-boot Configuring for omap3_sdp3430 board... text data bss dec hex filename 166579 4970 214828 386377 5e549 ./u-boot Configuring for omap3_zoom1 board... text data bss dec hex filename 179426 9708 201612 390746 5f65a ./u-boot Configuring for omap3_zoom2 board... text data bss dec hex filename 149680 8532 200392 358604 578cc ./u-boot Configuring for omap4_panda board... text data bss dec hex filename 104642 4540 200036 309218 4b7e2 ./u-boot Configuring for omap4_sdp4430 board... text data bss dec hex filename 104639 4540 200036 309215 4b7df ./u-boot Configuring for s5p_goni board... text data bss dec hex filename 122092 7348 12936 142376 22c28 ./u-boot Configuring for smdkc100 board... text data bss dec hex filename 156775 7844 221676 386295 5e4f7 ./u-boot --------------------- SUMMARY ---------------------------- Boards compiled: 14 ---------------------------------------------------------- Regards, Steve