From: Haiying Wang <Haiying.Wang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] powerpc/85xx: do not reloc l2srbar if CONFIG_FLASH_BASE is not defined
Date: Mon, 16 Aug 2010 23:50:36 -0400 [thread overview]
Message-ID: <1282017036.2814.19.camel@localhost.localdomain> (raw)
In-Reply-To: <20100816101116.8F1541606A5@gemini.denx.de>
On Mon, 2010-16-08 at 12:11 +0200, Wolfgang Denk wrote:
> >
> > diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init.c b/arch/powerpc/cpu/mpc85xx/cpu_init.c
> > index 2c3be6d..1fbc0cc 100644
> > --- a/arch/powerpc/cpu/mpc85xx/cpu_init.c
> > +++ b/arch/powerpc/cpu/mpc85xx/cpu_init.c
> > @@ -327,7 +327,7 @@ int cpu_init_r(void)
> > if (l2cache->l2ctl & MPC85xx_L2CTL_L2E) {
> > puts("already enabled");
> > l2srbar = l2cache->l2srbar0;
> > -#ifdef CONFIG_SYS_INIT_L2_ADDR
> > +#if defined(CONFIG_SYS_INIT_L2_ADDR) && defined(CONFIG_SYS_FLASH_BASE)
> > if (l2cache->l2ctl & MPC85xx_L2CTL_L2SRAM_ENTIRE
> > && l2srbar >= CONFIG_SYS_FLASH_BASE) {
>
> Does this commit not break systems which have CONFIG_SYS_FLASH_BASE
> defined, but with l2srbar < CONFIG_SYS_FLASH_BASE ?
I did not see it breaks the system in that case. It only affects the system without CONFIG_SYS_FLASH_BASE defined. :)
Haiying
next prev parent reply other threads:[~2010-08-17 3:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 8:04 [U-Boot] [PATCH 2/7] powerpc/85xx: do not reloc l2srbar if CONFIG_FLASH_BASE is not defined Haiying Wang
2010-08-16 10:11 ` Wolfgang Denk
2010-08-17 3:50 ` Haiying Wang [this message]
2010-08-17 5:28 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282017036.2814.19.camel@localhost.localdomain \
--to=haiying.wang@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox