public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: Cleanup BOOTFLAG_* usage
Date: Mon, 13 Sep 2010 09:53:05 -0500	[thread overview]
Message-ID: <1284389585.26713.2967.camel@petert> (raw)
In-Reply-To: <201009130827.21823.sr@denx.de>

On Mon, 2010-09-13 at 08:27 +0200, Stefan Roese wrote:
> On Monday 13 September 2010 07:34:40 Wolfgang Denk wrote:
> > > BOOTFLAG_COLD and BOOTFLAG_WARM have identical definitions for every
> > > PowerPC board, so share a common definition.
> > > 
> > > Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> > > ---
> > > It looks like there are only a few boards (5) that use the warm/cold
> > > boot concept, maybe we should remove this largely unused feature?
> > > Or at least remove it for most CPU types?  Is anyone out there
> > > using it?
> > 
> > I added this with the very first versions of PPCBoot, more than a
> > decade ago. I've never seen it really used in the code.
> > 
> > I vote for removing it.
> 
> Me too:
> 
> Acked-by: Stefan Roese <sr@denx.de>

Sounds good, I'll resubmit.  Getting rid of the BOOTFLAG_* defines will
make bd->bi_bootflags unused.  What's the policy on modifying the
bd_info structure?  Leave an unused bi_bootflags field to prevent
breakage of OSes?

Best,
Peter

  reply	other threads:[~2010-09-13 14:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13  5:21 [U-Boot] [PATCH] powerpc: Cleanup BOOTFLAG_* usage Peter Tyser
2010-09-13  5:34 ` Wolfgang Denk
2010-09-13  6:27   ` Stefan Roese
2010-09-13 14:53     ` Peter Tyser [this message]
2010-09-13 22:02       ` Wolfgang Denk
2010-09-13 22:13         ` Scott Wood
2010-09-14  2:40           ` Peter Tyser
2010-10-12 20:49 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284389585.26713.2967.camel@petert \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox